Bug 201301 - [WPE][Qt] loadingChanged signal parameter is unusable
Summary: [WPE][Qt] loadingChanged signal parameter is unusable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-29 06:53 PDT by Philippe Normand
Modified: 2019-08-30 01:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.47 KB, patch)
2019-08-29 06:56 PDT, Philippe Normand 		cgarcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2019-08-29 06:53:30 PDT 
The WPEQtView class can't rely on the readability/parameter_name rule,
because omitting parameter names for QML signals leads to runtime
errors.
Comment 1 Philippe Normand 2019-08-29 06:56:50 PDT 
Created attachment 377578 [details]
Patch
Comment 2 Philippe Normand 2019-08-30 01:29:58 PDT 
Committed r249318: <https://trac.webkit.org/changeset/249318>