Bug 201220 - [GStreamer] Do not use makeWeakPtr from streaming thread.
Summary: [GStreamer] Do not use makeWeakPtr from streaming thread.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charlie Turner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-28 08:48 PDT by Charlie Turner
Modified: 2019-08-29 09:14 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.28 KB, patch)
2019-08-28 09:01 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Patch (2.13 KB, patch)
2019-08-29 03:22 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Turner 2019-08-28 08:48:27 PDT 
[GStreamer] Do not use makeWeakPtr from streaming thread.
Comment 1 Charlie Turner 2019-08-28 09:01:29 PDT 
Created attachment 377448 [details]
Patch
Comment 2 Alex Christensen 2019-08-28 11:38:54 PDT 
Comment on attachment 377448 [details]
Patch

This is what WeakPtrFactoryInitialization::Eager is for.
Comment 3 Charlie Turner 2019-08-29 03:22:56 PDT 
Created attachment 377565 [details]
Patch
Comment 4 WebKit Commit Bot 2019-08-29 09:14:13 PDT 
Comment on attachment 377565 [details]
Patch

Clearing flags on attachment: 377565

Committed r249276: <https://trac.webkit.org/changeset/249276>
Comment 5 WebKit Commit Bot 2019-08-29 09:14:15 PDT 
All reviewed patches have been landed.  Closing bug.