Bug 201049 - [Subpixel layout] reddit.com comments are slightly scrollable
Summary: [Subpixel layout] reddit.com comments are slightly scrollable
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-22 13:08 PDT by zalan
Modified: 2019-08-22 15:00 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.91 KB, patch)
2019-08-22 13:19 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (6.89 KB, patch)
2019-08-22 13:23 PDT, zalan
simon.fraser: review+
Details | Formatted Diff | Diff
Archive of layout-test-results from ews215 for win-future (13.66 MB, application/zip)
2019-08-22 14:59 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-08-22 13:08:38 PDT
<rdar://problem/49951104>
Comment 1 zalan 2019-08-22 13:19:13 PDT
Created attachment 377037 [details]
Patch
Comment 2 zalan 2019-08-22 13:23:46 PDT
Created attachment 377038 [details]
Patch
Comment 3 Simon Fraser (smfr) 2019-08-22 13:38:11 PDT
Comment on attachment 377038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377038&action=review

> Source/WebCore/ChangeLog:9
> +        Since RootLines are forced to be on integral positions, we need to ensure that the block container's height is adjusted accordingly (to always enclose the lines in the case of LayoutUnit -> int conversion).  

Need more explanation here.
Comment 4 Build Bot 2019-08-22 14:59:15 PDT
Comment on attachment 377038 [details]
Patch

Attachment 377038 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12957981

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2019-08-22 14:59:17 PDT
Created attachment 377057 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 6 zalan 2019-08-22 14:59:54 PDT
(In reply to Build Bot from comment #5)
> Created attachment 377057 [details]
> Archive of layout-test-results from ews215 for win-future
> 
> The attached test failures were seen while running run-webkit-tests on the
> win-ews.
> Bot: ews215  Port: win-future  Platform:
> CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
ofc.