201004 – [ews] Fix capitalization in Found x new Test failure message

RESOLVED FIXED 201004

[ews] Fix capitalization in Found x new Test failure message

https://bugs.webkit.org/show_bug.cgi?id=201004

Summary [ews] Fix capitalization in Found x new Test failure message

Aakash Jain

Reported 2019-08-21 15:50:53 PDT

Fix capitalization in 'Found x new Test failure' message. It should be 'test' instead of 'Test'.

Attachments
Patch (4.51 KB, patch) 2019-08-21 15:57 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-08-21 15:57:02 PDT

Created attachment 376942 [details] Patch

EWS Watchlist

Comment 2 2019-08-21 15:58:54 PDT Comment hidden (obsolete)

Attachment 376942 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1270: [TestAnalyzeLayoutTestsResults.test_failure_introduced_by_patch] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1270: [TestAnalyzeLayoutTestsResults.test_failure_introduced_by_patch] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1285: [TestAnalyzeLayoutTestsResults.test_flaky_and_consistent_failures_without_clean_tree_failures] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1285: [TestAnalyzeLayoutTestsResults.test_flaky_and_consistent_failures_without_clean_tree_failures] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1353: [TestAnalyzeLayoutTestsResults.test_clean_tree_has_some_failures] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1353: [TestAnalyzeLayoutTestsResults.test_clean_tree_has_some_failures] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 3 2019-08-21 16:51:40 PDT

Comment on attachment 376942 [details] Patch Clearing flags on attachment: 376942 Committed r248975: <https://trac.webkit.org/changeset/248975>

WebKit Commit Bot

Comment 4 2019-08-21 16:51:41 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 5 2019-08-21 16:52:19 PDT

<rdar://problem/54578430>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version Other

Hardware Unspecified

OS Unspecified

Product WebKit

Component Tools / Tests

Assignee

Aakash Jain

Reported

2019-08-21 15:50 PDT

Modified

2019-08-21 16:52 PDT History

CC List

6 users Show

URL

Keywords InRadar

Depends on

Blocks