Bug 200867 - [JSC] Add B3 Mul strength-reduction for Float
Summary: [JSC] Add B3 Mul strength-reduction for Float
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-17 22:54 PDT by Yusuke Suzuki
Modified: 2019-08-18 01:05 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2019-08-17 22:54 PDT, Yusuke Suzuki 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-08-17 22:54:19 PDT 
[JSC] Add B3 Mul strength-reduction for Float
Comment 1 Yusuke Suzuki 2019-08-17 22:54:51 PDT 
Created attachment 376629 [details]
Patch
Comment 2 Yusuke Suzuki 2019-08-18 00:19:19 PDT 
This does not preserve signaling NaN. So this optimization is wrong.
And we have this optimization for double, and it is also wrong.
But this optimization is OK if the B3 comes from JS, since we ensured that JS does not produce signaling NaN.
Comment 3 EWS Watchlist 2019-08-18 01:05:10 PDT 
Comment on attachment 376629 [details]
Patch

Attachment 376629 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/12934628

New failing tests:
wasm.yaml/wasm/spec-tests/float_exprs.wast.js.wasm-no-air