Bug 200785 - [WHLSL] Don't accept operator&& or operator|| in the Lexer
Summary: [WHLSL] Don't accept operator&& or operator|| in the Lexer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-15 13:20 PDT by Robin Morisset
Modified: 2019-08-15 14:19 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.68 KB, patch)
2019-08-15 13:29 PDT, Robin Morisset
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-08-15 13:20:33 PDT
They don't make sense: implementing && or || as function calls would lose us short-circuiting.
Comment 1 Robin Morisset 2019-08-15 13:29:18 PDT
Created attachment 376415 [details]
Patch
Comment 2 WebKit Commit Bot 2019-08-15 14:18:17 PDT
Comment on attachment 376415 [details]
Patch

Clearing flags on attachment: 376415

Committed r248746: <https://trac.webkit.org/changeset/248746>
Comment 3 WebKit Commit Bot 2019-08-15 14:18:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-08-15 14:19:17 PDT
<rdar://problem/54362301>