Bug 200713 – Make mock libwebrtc tests run with unified plan

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Make mock libwebrtc tests run with unified plan

[youenn fablet]

Created attachment 376262 [details]
Patch

[youenn fablet]

Created attachment 376263 [details]
Patch

[EWS Watchlist]

Attachment 376263 [details] did not pass style-queue:


ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:170:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:194:  media_type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:213:  media_type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:214:  Use 'WTF::Optional<>' instead of 'std::optional<>'.  [runtime/wtf_optional] [4]
ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:219:  Use 'WTF::Optional<>' instead of 'std::optional<>'.  [runtime/wtf_optional] [4]
ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:219:  current_direction is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:232:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:235:  local_streams is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:236:  remote_streams is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:237:  local_description is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:238:  remote_description is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:240:  signaling_state is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:241:  ice_connection_state is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:242:  ice_gathering_state is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 14 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 376263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376263&action=review

> LayoutTests/fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html:-10
> -                testRunner.setWebRTCUnifiedPlanEnabled(false);

Could we also remove this from TestRunner.idl and the related piping?

[youenn fablet]

(In reply to Alex Christensen from comment #4)
> Comment on attachment 376263 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=376263&action=review
> 
> > LayoutTests/fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html:-10
> > -                testRunner.setWebRTCUnifiedPlanEnabled(false);
> 
> Could we also remove this from TestRunner.idl and the related piping?

Not yet, this is required by some tests specific to plan B for the moment.

[WebKit Commit Bot]

Comment on attachment 376263 [details]
Patch

Clearing flags on attachment: 376263

Committed r248718: <https://trac.webkit.org/changeset/248718>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54351089>