Bug 200453 - [iPadOS] Unable to increase zoom level on Google using the Aa menu
Summary: [iPadOS] Unable to increase zoom level on Google using the Aa menu
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
Keywords: InRadar
Depends on:
Reported: 2019-08-05 16:06 PDT by Wenson Hsieh
Modified: 2019-08-06 07:49 PDT (History)
6 users (show)

See Also:

Patch (15.59 KB, patch)
2019-08-05 19:28 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-08-05 16:06:32 PDT
Comment 1 Wenson Hsieh 2019-08-05 19:28:22 PDT
Created attachment 375596 [details]
Comment 2 Tim Horton 2019-08-05 22:01:41 PDT
Comment on attachment 375596 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=375596&action=review

> Source/WebCore/page/ViewportConfiguration.cpp:250
> +        return clampTo<double>(initialScale, shouldIgnoreScalingConstraints ? m_defaultConfiguration.minimumScale : m_configuration.minimumScale, m_configuration.maximumScale);

Woah, there are some other places we should use this
Comment 3 WebKit Commit Bot 2019-08-06 07:49:31 PDT
Comment on attachment 375596 [details]

Clearing flags on attachment: 375596

Committed r248292: <https://trac.webkit.org/changeset/248292>
Comment 4 WebKit Commit Bot 2019-08-06 07:49:32 PDT
All reviewed patches have been landed.  Closing bug.