RESOLVED FIXED 200446
Add test for behavior introduced in r248174 
https://bugs.webkit.org/show_bug.cgi?id=200446
Summary Add test for behavior introduced in r248174
Jer Noble
Reported 2019-08-05 13:35:03 PDT
Add test for behavior introduced in r248174
Attachments
Patch (31.40 KB, patch)
2019-08-05 13:37 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2019-08-05 13:37:39 PDT
Created attachment 375550 [details] Patch
EWS Watchlist
Comment 2 2019-08-05 13:40:06 PDT
Attachment 375550 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp:28: You should add a blank line after implementation file's own header. [build/include_order] [4] ERROR: Tools/TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp:28: You should not add a blank line before implementation file's own header. [build/include_order] [4] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jer Noble
Comment 3 2019-08-05 14:00:25 PDT
(In reply to Build Bot from comment #2) > Attachment 375550 [details] did not pass style-queue: > > > ERROR: > Tools/TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp:28: You > should add a blank line after implementation file's own header. > [build/include_order] [4] > ERROR: > Tools/TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp:28: You > should not add a blank line before implementation file's own header. > [build/include_order] [4] > Total errors found: 2 in 10 files Amazing. The implementation file in question doesn't even have its own header.
Eric Carlson
Comment 4 2019-08-05 17:57:16 PDT
Comment on attachment 375550 [details] Patch very nice!
WebKit Commit Bot
Comment 5 2019-08-06 10:34:33 PDT
Comment on attachment 375550 [details] Patch Clearing flags on attachment: 375550 Committed r248302: <https://trac.webkit.org/changeset/248302>
WebKit Commit Bot
Comment 6 2019-08-06 10:34:35 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-08-06 10:35:18 PDT
<rdar://problem/53992338>
Note You need to log in before you can comment on or make changes to this bug.