Bug 200430 - [LFC] Remove out-of-flow descendants from Container
Summary: [LFC] Remove out-of-flow descendants from Container
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-04 16:24 PDT by zalan
Modified: 2019-08-05 22:20 PDT (History)
6 users (show)

See Also:


Attachments
Patch (17.89 KB, patch)
2019-08-04 16:28 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (17.94 KB, patch)
2019-08-05 22:03 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-08-04 16:24:43 PDT
this is the last "formatting context type" bit in layout tree.
Comment 1 Radar WebKit Bug Importer 2019-08-04 16:25:15 PDT
<rdar://problem/53923980>
Comment 2 zalan 2019-08-04 16:28:38 PDT
Created attachment 375510 [details]
Patch
Comment 3 Antti Koivisto 2019-08-05 10:06:45 PDT
Comment on attachment 375510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375510&action=review

> Source/WebCore/layout/LayoutState.cpp:205
> +    auto quirksMode = QuirksMode::No;
> +    if (renderView.document().inLimitedQuirksMode())
> +        quirksMode = QuirksMode::Limited;
> +    else if (renderView.document().inQuirksMode())
> +        quirksMode = QuirksMode::Yes;

This might be nicer as a lambda.
Comment 4 zalan 2019-08-05 22:03:06 PDT
Created attachment 375600 [details]
Patch
Comment 5 zalan 2019-08-05 22:03:51 PDT
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 375510 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375510&action=review
> 
> > Source/WebCore/layout/LayoutState.cpp:205
> > +    auto quirksMode = QuirksMode::No;
> > +    if (renderView.document().inLimitedQuirksMode())
> > +        quirksMode = QuirksMode::Limited;
> > +    else if (renderView.document().inQuirksMode())
> > +        quirksMode = QuirksMode::Yes;
> 
> This might be nicer as a lambda.
Good idea.
Comment 6 WebKit Commit Bot 2019-08-05 22:20:15 PDT
Comment on attachment 375600 [details]
Patch

Clearing flags on attachment: 375600

Committed r248290: <https://trac.webkit.org/changeset/248290>
Comment 7 WebKit Commit Bot 2019-08-05 22:20:17 PDT
All reviewed patches have been landed.  Closing bug.