RESOLVED FIXED 200430
[LFC] Remove out-of-flow descendants from Container 
https://bugs.webkit.org/show_bug.cgi?id=200430
Summary [LFC] Remove out-of-flow descendants from Container
alan
Reported 2019-08-04 16:24:43 PDT
this is the last "formatting context type" bit in layout tree.
Attachments
Patch (17.89 KB, patch)
2019-08-04 16:28 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (17.94 KB, patch)
2019-08-05 22:03 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-08-04 16:25:15 PDT
<rdar://problem/53923980>
alan
Comment 2 2019-08-04 16:28:38 PDT
Created attachment 375510 [details] Patch
Antti Koivisto
Comment 3 2019-08-05 10:06:45 PDT
Comment on attachment 375510 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375510&action=review > Source/WebCore/layout/LayoutState.cpp:205 > + auto quirksMode = QuirksMode::No; > + if (renderView.document().inLimitedQuirksMode()) > + quirksMode = QuirksMode::Limited; > + else if (renderView.document().inQuirksMode()) > + quirksMode = QuirksMode::Yes; This might be nicer as a lambda.
alan
Comment 4 2019-08-05 22:03:06 PDT
Created attachment 375600 [details] Patch
alan
Comment 5 2019-08-05 22:03:51 PDT
(In reply to Antti Koivisto from comment #3) > Comment on attachment 375510 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=375510&action=review > > > Source/WebCore/layout/LayoutState.cpp:205 > > + auto quirksMode = QuirksMode::No; > > + if (renderView.document().inLimitedQuirksMode()) > > + quirksMode = QuirksMode::Limited; > > + else if (renderView.document().inQuirksMode()) > > + quirksMode = QuirksMode::Yes; > > This might be nicer as a lambda. Good idea.
WebKit Commit Bot
Comment 6 2019-08-05 22:20:15 PDT
Comment on attachment 375600 [details] Patch Clearing flags on attachment: 375600 Committed r248290: <https://trac.webkit.org/changeset/248290>
WebKit Commit Bot
Comment 7 2019-08-05 22:20:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.