Bug 200039 - Enable pageAtRuleSupportEnabled
Summary: Enable pageAtRuleSupportEnabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-23 12:08 PDT by Keith Rollin
Modified: 2023-11-24 07:28 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.53 KB, patch)
2019-07-23 12:34 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
Patch (2.53 KB, patch)
2019-07-23 12:39 PDT, Keith Rollin 		zalan: review+
zalan: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-07-23 12:08:31 PDT 
Alan says this should be enabled in shipping branches.
Comment 1 Radar WebKit Bug Importer 2019-07-23 12:08:49 PDT 
<rdar://problem/53457531>
Comment 2 Keith Rollin 2019-07-23 12:09:07 PDT 
Alan, can you provide me a comment for the change log?
Comment 3 Keith Rollin 2019-07-23 12:34:25 PDT 
Created attachment 374695 [details]
Patch
Comment 4 Keith Rollin 2019-07-23 12:34:47 PDT 
Comment on attachment 374695 [details]
Patch

I'm cq-'ing so that this doesn't get landed in trunk. But it still needs review.
Comment 5 zalan 2019-07-23 12:36:15 PDT 
Comment on attachment 374695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374695&action=review

> Source/WebCore/ChangeLog:9
> +        Alan says we want this enabled.

Enable support for @page margin.

> Source/WebKit/ChangeLog:9
> +        Alan says we want this enabled.

Enable support for @page margin.
Comment 6 Keith Rollin 2019-07-23 12:39:21 PDT 
Created attachment 374698 [details]
Patch