Bug 200022 - Fix WebView iframe rendering in macOS Catalina
Summary: Fix WebView iframe rendering in macOS Catalina
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-22 18:17 PDT by Simon Fraser (smfr)
Modified: 2019-07-22 19:08 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.25 KB, patch)
2019-07-22 18:19 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-07-22 18:17:42 PDT 
Fix WebView iframe rendering in macOS Catalina
Comment 1 Simon Fraser (smfr) 2019-07-22 18:19:09 PDT 
Created attachment 374660 [details]
Patch
Comment 2 Simon Fraser (smfr) 2019-07-22 18:19:10 PDT 
<rdar://problem/49102040>
Comment 3 EWS Watchlist 2019-07-22 18:22:03 PDT 
Attachment 374660 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:728:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:730:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:1675:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:1677:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:1686:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
ERROR: Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:1688:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 6 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2019-07-22 19:08:26 PDT 
Comment on attachment 374660 [details]
Patch

Clearing flags on attachment: 374660

Committed r247712: <https://trac.webkit.org/changeset/247712>
Comment 5 WebKit Commit Bot 2019-07-22 19:08:28 PDT 
All reviewed patches have been landed.  Closing bug.