Bug 199581 – Hop explicitly to the main thread after generating a frame in ScreenDisplayCaptureSourceMac

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Hop explicitly to the main thread after generating a frame in ScreenDisplayCaptureSourceMac

[youenn fablet]

Created attachment 373648 [details]
Patch

[Eric Carlson]

Comment on attachment 373648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373648&action=review

> Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:169
> +                weakThis->newFrame(status, WTFMove(frame));

There isn't a lot of code in newFrame now, it might make sense to move it here.

[youenn fablet]

Comment on attachment 373648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373648&action=review

>> Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:169
>> +                weakThis->newFrame(status, WTFMove(frame));
> 
> There isn't a lot of code in newFrame now, it might make sense to move it here.

It makes a nice separation between main-thread/non main thread.
And we might want to beef-up newFrame so that it becomes something like generateNewFrame if we get rid of the timer.

[Radar WebKit Bug Importer]

<rdar://problem/52803327>

[WebKit Commit Bot]

Comment on attachment 373648 [details]
Patch

Clearing flags on attachment: 373648

Committed r247238: <https://trac.webkit.org/changeset/247238>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.