Bug 199509 - Import css/cssom-view test cases from WPT
Summary: Import css/cssom-view test cases from WPT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: cathiechen
URL:
Keywords: InRadar
Depends on:
Blocks: 161611
  Show dependency treegraph
 
Reported: 2019-07-05 00:44 PDT by cathiechen
Modified: 2019-07-06 04:05 PDT (History)
7 users (show)

See Also:


Attachments
Patch (175.89 KB, patch)
2019-07-05 02:59 PDT, cathiechen
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.72 MB, application/zip)
2019-07-05 04:56 PDT, EWS Watchlist
no flags Details
Patch (179.32 KB, patch)
2019-07-05 07:21 PDT, cathiechen
no flags Details | Formatted Diff | Diff
Patch (179.81 KB, patch)
2019-07-05 09:43 PDT, cathiechen
no flags Details | Formatted Diff | Diff
Patch (179.82 KB, patch)
2019-07-06 03:16 PDT, cathiechen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description cathiechen 2019-07-05 00:44:55 PDT
Import css/cssom-view test cases from WPT.
Comment 1 cathiechen 2019-07-05 02:59:49 PDT
Created attachment 373486 [details]
Patch
Comment 2 EWS Watchlist 2019-07-05 04:56:41 PDT
Comment on attachment 373486 [details]
Patch

Attachment 373486 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12666833

New failing tests:
imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-leading-space-inline.html
imported/w3c/web-platform-tests/css/cssom-view/scrollIntoView-horizontal-tb-writing-mode-and-rtl-direction.html
imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-empty-inline.html
Comment 3 EWS Watchlist 2019-07-05 04:56:43 PDT
Created attachment 373489 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5
Comment 4 cathiechen 2019-07-05 07:21:14 PDT
Created attachment 373492 [details]
Patch
Comment 5 cathiechen 2019-07-05 09:43:13 PDT
Created attachment 373504 [details]
Patch
Comment 6 WebKit Commit Bot 2019-07-06 03:02:34 PDT
Comment on attachment 373504 [details]
Patch

Rejecting attachment 373504 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 373504, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Frederic Wang found in /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/12674725
Comment 7 cathiechen 2019-07-06 03:16:24 PDT
Created attachment 373565 [details]
Patch
Comment 8 WebKit Commit Bot 2019-07-06 04:04:05 PDT
Comment on attachment 373565 [details]
Patch

Clearing flags on attachment: 373565

Committed r247193: <https://trac.webkit.org/changeset/247193>
Comment 9 WebKit Commit Bot 2019-07-06 04:04:06 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-07-06 04:05:18 PDT
<rdar://problem/52720270>