Bug 199309 – Web Inspector: support `console.screenshot` with detached Nodes that are graphical

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

This includes the likes of HTMLImageElement, HTMLPictureElement, HTMLVideoElement, HTMLCanvasElement, etc.

[Devin Rousso]

Created attachment 373088 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 373088 [details]
Patch

Might be nice to have tests for a <picture> / <video> as well. rs=me

[Devin Rousso]

Created attachment 374832 [details]
Patch

[Devin Rousso]

Created attachment 374847 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 374847 [details]
Patch

Rejecting attachment 374847 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 374847, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=374847&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=199309&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 374847 from bug 199309.
Fetching: https://bugs.webkit.org/attachment.cgi?id=374847
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 5 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 1.
patching file Source/WebCore/page/PageConsoleClient.cpp
Hunk #1 FAILED at 29.
Hunk #2 succeeded at 291 with fuzz 1 (offset 4 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/page/PageConsoleClient.cpp.rej
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/inspector/console/console-screenshot-expected.txt
Hunk #1 succeeded at 1 with fuzz 2.
Hunk #2 succeeded at 24 (offset 2 lines).
patching file LayoutTests/inspector/console/console-screenshot.html
Hunk #1 succeeded at 21 with fuzz 1 (offset 10 lines).
Hunk #2 succeeded at 106 (offset 10 lines).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/12806110

[Devin Rousso]

Created attachment 374852 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 374852 [details]
Patch

Clearing flags on attachment: 374852

Committed r247814: <https://trac.webkit.org/changeset/247814>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/53526182>