Bug 198934 - [WHLSL] Remove backtracking from parseAttributeBlock
Summary: [WHLSL] Remove backtracking from parseAttributeBlock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks: 198357
  Show dependency tree / graph
 
Reported: 2019-06-17 15:13 PDT by Robin Morisset
Modified: 2019-06-17 16:08 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2019-06-17 15:16 PDT, Robin Morisset 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-06-17 15:13:44 PDT 
It is one of 3 places left in the parser that use backtrackingScope, and it is by far the simplest to remove.
Comment 1 Robin Morisset 2019-06-17 15:16:28 PDT 
Created attachment 372277 [details]
Patch
Comment 2 WebKit Commit Bot 2019-06-17 16:07:38 PDT 
Comment on attachment 372277 [details]
Patch

Clearing flags on attachment: 372277

Committed r246520: <https://trac.webkit.org/changeset/246520>
Comment 3 WebKit Commit Bot 2019-06-17 16:07:39 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-06-17 16:08:18 PDT 
<rdar://problem/51825612>