Bug 198612 - REGRESSION(244439): platform/mac/media/encrypted-media/fps-* tests are crashing
Summary: REGRESSION(244439): platform/mac/media/encrypted-media/fps-* tests are crashing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-06 09:32 PDT by Jer Noble
Modified: 2019-06-14 13:10 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.42 KB, patch)
2019-06-06 09:37 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (9.42 KB, patch)
2019-06-06 13:31 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (9.38 KB, patch)
2019-06-14 12:27 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2019-06-06 09:32:43 PDT 
REGRESSION(244439): platform/mac/media/encrypted-media/fps-* tests are crashing
Comment 1 Jer Noble 2019-06-06 09:33:24 PDT 
<rdar://problem/51078978>
Comment 2 Jer Noble 2019-06-06 09:37:17 PDT 
Created attachment 371503 [details]
Patch
Comment 3 Eric Carlson 2019-06-06 13:29:54 PDT 
Comment on attachment 371503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371503&action=review

> Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp:135
> +        if (psshBox.systemID() != CDMPrivateFairPlayStreaming::fairPlaySystemID()) {

I think you want an “==“ here
Comment 4 Jer Noble 2019-06-06 13:31:52 PDT 
Created attachment 371522 [details]
Patch
Comment 5 Jer Noble 2019-06-14 12:27:27 PDT 
Created attachment 372132 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-06-14 13:10:39 PDT 
Comment on attachment 372132 [details]
Patch for landing

Clearing flags on attachment: 372132

Committed r246441: <https://trac.webkit.org/changeset/246441>
Comment 7 WebKit Commit Bot 2019-06-14 13:10:41 PDT 
All reviewed patches have been landed.  Closing bug.