Bug 198596 - Web Inspector: Go To Line dialog is white when in Dark Mode
Summary: Web Inspector: Go To Line dialog is white when in Dark Mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-05 19:36 PDT by Devin Rousso
Modified: 2019-06-17 12:30 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.72 KB, patch)
2019-06-07 15:04 PDT, Jamal Nasser 		no flags Details | Formatted Diff | Diff
Patch applied (165.88 KB, image/png)
2019-06-07 15:25 PDT, Jamal Nasser 		no flags Details
Patch (1.72 KB, patch)
2019-06-14 23:49 PDT, Jamal Nasser 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-06-05 19:36:13 PDT 
# STEPS TO REPRODUCE:
1. switch to Dark Mode
2. inspect any page
3. go to any resource in the Resources/Debugger/Sources tab
4. press ⌃G
 => the "Line Number" dialog is white
Comment 1 Jamal Nasser 2019-06-07 15:04:03 PDT 
Created attachment 371615 [details]
Patch
Comment 2 Jamal Nasser 2019-06-07 15:25:09 PDT 
Created attachment 371617 [details]
Patch applied
Comment 3 Devin Rousso 2019-06-07 15:32:42 PDT 
Comment on attachment 371615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371615&action=review

r=me, nice!

> Source/WebInspectorUI/UserInterface/Views/GoToLineDialog.css:98
> +

Style: extra newline.

> Source/WebInspectorUI/UserInterface/Views/GoToLineDialog.css:115
> +

Ditto (>98).
Comment 4 Devin Rousso 2019-06-11 15:10:40 PDT 
@Jamal if you upload another patch with the whitespace removed, I'll cq+ this for you :)
Comment 5 Jamal Nasser 2019-06-14 23:49:18 PDT 
Created attachment 372177 [details]
Patch
Comment 6 WebKit Commit Bot 2019-06-17 12:29:24 PDT 
Comment on attachment 372177 [details]
Patch

Clearing flags on attachment: 372177

Committed r246508: <https://trac.webkit.org/changeset/246508>
Comment 7 WebKit Commit Bot 2019-06-17 12:29:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-06-17 12:30:34 PDT 
<rdar://problem/51816116>