Bug 198588 - [macOS] Stop calling -[NSDraggingItem setItem:]
Summary: [macOS] Stop calling -[NSDraggingItem setItem:]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-05 16:49 PDT by Andy Estes
Modified: 2019-06-05 20:24 PDT (History)
6 users (show)

See Also:


Attachments
Patch (22.06 KB, patch)
2019-06-05 16:54 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2019-06-05 16:49:23 PDT
[macOS] Stop calling -[NSDraggingItem setItem:]
Comment 1 Andy Estes 2019-06-05 16:49:41 PDT
rdar://problem/48297453
Comment 2 Andy Estes 2019-06-05 16:54:42 PDT
Created attachment 371450 [details]
Patch
Comment 3 EWS Watchlist 2019-06-05 16:57:04 PDT
Attachment 371450 [details] did not pass style-queue:


ERROR: Tools/TestRunnerShared/spi/AppKitTestSPI.h:42:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2019-06-05 20:24:27 PDT
Comment on attachment 371450 [details]
Patch

Clearing flags on attachment: 371450

Committed r246141: <https://trac.webkit.org/changeset/246141>
Comment 5 WebKit Commit Bot 2019-06-05 20:24:28 PDT
All reviewed patches have been landed.  Closing bug.