Bug 198562 - [ARM64E]: Add disassembler support for authenticated instructions
Summary: [ARM64E]: Add disassembler support for authenticated instructions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-05 05:27 PDT by Michael Saboff
Modified: 2019-06-06 02:31 PDT (History)
5 users (show)

See Also:


Attachments
Patch (11.87 KB, patch)
2019-06-05 06:19 PDT, Michael Saboff
keith_miller: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.62 MB, application/zip)
2019-06-05 08:15 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2019-06-05 05:27:43 PDT
The authenticate pointer instructions are provided for in the ARM64e assembler and macro assembler.  Those instructions should be supported by the disassembler.
Comment 1 Radar WebKit Bug Importer 2019-06-05 05:28:41 PDT
<rdar://problem/51437410>
Comment 2 Michael Saboff 2019-06-05 06:19:05 PDT
Created attachment 371391 [details]
Patch
Comment 3 EWS Watchlist 2019-06-05 08:15:28 PDT
Comment on attachment 371391 [details]
Patch

Attachment 371391 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12384211

New failing tests:
http/wpt/service-workers/service-worker-networkprocess-crash.html
Comment 4 EWS Watchlist 2019-06-05 08:15:29 PDT
Created attachment 371397 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5
Comment 5 Keith Miller 2019-06-06 02:24:11 PDT
Comment on attachment 371391 [details]
Patch

rs=me
Comment 6 Michael Saboff 2019-06-06 02:31:43 PDT
Committed r246147: <https://trac.webkit.org/changeset/246147>