198546 – Web Inspector: Dark Mode: inactive tab bar tint is too light

Bug 198546 - Web Inspector: Dark Mode: inactive tab bar tint is too light

Summary: Web Inspector: Dark Mode: inactive tab bar tint is too light

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Inspector (show other bugs)
Version:	WebKit Nightly Build
Hardware:	All All

Importance:	P2 Normal
Assignee:	Devin Rousso

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2019-06-04 15:56 PDT by Devin Rousso
Modified:	2019-06-05 11:30 PDT (History)
CC List:	7 users (show)

See Also:

Attachments
Patch (1.18 KB, patch) 2019-06-04 17:19 PDT, Devin Rousso	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.95 MB, application/zip) 2019-06-04 21:20 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Devin Rousso 2019-06-04 15:56:27 PDT

It doesn’t match the tint of Safari :(

Comment 1 Devin Rousso 2019-06-04 17:19:14 PDT

Created attachment 371354 [details]
Patch

Comment 2 EWS Watchlist 2019-06-04 21:20:30 PDT Comment hidden (obsolete)

Comment on attachment 371354 [details]
Patch

Attachment 371354 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12380793

New failing tests:
http/wpt/service-workers/service-worker-networkprocess-crash.html

Comment 3 EWS Watchlist 2019-06-04 21:20:32 PDT Comment hidden (obsolete)

Created attachment 371372 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

Comment 4 Joseph Pecoraro 2019-06-05 10:56:35 PDT

Comment on attachment 371354 [details]
Patch

rs=me

Comment 5 WebKit Commit Bot 2019-06-05 11:29:40 PDT

Comment on attachment 371354 [details]
Patch

Clearing flags on attachment: 371354

Committed r246120: <https://trac.webkit.org/changeset/246120>

Comment 6 WebKit Commit Bot 2019-06-05 11:29:42 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 Radar WebKit Bug Importer 2019-06-05 11:30:25 PDT

<rdar://problem/51448986>