Bug 198531 – Improve accessibility on webkit.org

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Website

[Jon Davis]

Add aria-label to blog post icons and expected menuitem roles to WordPress driven menus.

[Jon Davis]

Created attachment 371295 [details]
Patch

[Devin Rousso]

Comment on attachment 371295 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371295&action=review

r=me

> Websites/webkit.org/ChangeLog:-101
> -        

I don't think we normally go back and edit ChangeLog entries, no matter how "bad" they may be.

[Devin Rousso]

Comment on attachment 371295 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371295&action=review

> Websites/webkit.org/wp-content/themes/webkit/widgets/post.php:71
> +                        <use xlink:href="#<?php echo esc_attr(get_post_icon()); ?>" aria-label="<?php echo esc_attr(str_replace('-',' ', get_post_icon())); ?> icon" />

Should we use the "category" as the title, or should we have something more related to the title of the post? (e.g. "performance" vs "introducing the jetstream 2 benchmark suite")

[EWS Watchlist]

Comment on attachment 371295 [details]
Patch

Attachment 371295 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12374944

New failing tests:
http/wpt/service-workers/service-worker-networkprocess-crash.html

[EWS Watchlist]

Created attachment 371310 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Comment on attachment 371295 [details]
Patch

Rejecting attachment 371295 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 371295, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=371295&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=198531&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 371295 from bug 198531.
Fetching: https://bugs.webkit.org/attachment.cgi?id=371295
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Devin Rousso']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 3 diffs from patch file(s).
patching file Websites/webkit.org/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
Hunk #2 FAILED at 108.
1 out of 2 hunks FAILED -- saving rejects to file Websites/webkit.org/ChangeLog.rej
patching file Websites/webkit.org/wp-content/themes/webkit/functions.php
patching file Websites/webkit.org/wp-content/themes/webkit/widgets/post.php

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Devin Rousso']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/12381318

[Jon Davis]

Created attachment 371396 [details]
Patch

[EWS]

Comment on attachment 371396 [details]
Patch

Rejecting attachment 371396 [details] from review queue.

[e-mail] does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Commit Bot]

Comment on attachment 371396 [details]
Patch

Clearing flags on attachment: 371396

Committed r246112: <https://trac.webkit.org/changeset/246112>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/51445063>