Bug 198474 - [WinCairo][MiniBrowser] WKViewSetIsInWindow should be called
Summary: [WinCairo][MiniBrowser] WKViewSetIsInWindow should be called
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 198281
  Show dependency treegraph
 
Reported: 2019-06-02 22:08 PDT by Fujii Hironori
Modified: 2019-06-02 22:30 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.54 KB, patch)
2019-06-02 22:12 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-06-02 22:08:34 PDT
[WinCairo][MiniBrowser] WKViewSetIsInWindow should be called

WinCairo WK2 MiniBrowser can't play back videos because
Page::canStartMedia() always returns false. WKViewSetIsInWindow
should be called.

The original MiniBrowser did it in Bug 55364.
Comment 1 Fujii Hironori 2019-06-02 22:12:21 PDT
Created attachment 371175 [details]
Patch
Comment 2 Fujii Hironori 2019-06-02 22:29:27 PDT
Comment on attachment 371175 [details]
Patch

Clearing flags on attachment: 371175

Committed r246028: <https://trac.webkit.org/changeset/246028>
Comment 3 Fujii Hironori 2019-06-02 22:29:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-06-02 22:30:57 PDT
<rdar://problem/51345666>