Bug 198378 - [iOS] Do not linkify telephone numbers inside <a> elements.
Summary: [iOS] Do not linkify telephone numbers inside <a> elements.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-30 09:26 PDT by zalan
Modified: 2019-05-30 12:42 PDT (History)
8 users (show)

See Also:


Attachments
Patch (5.23 KB, patch)
2019-05-30 10:02 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (5.32 KB, patch)
2019-05-30 11:05 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-05-30 09:26:49 PDT
rdar://problem/43208329
Comment 1 zalan 2019-05-30 10:02:58 PDT
Created attachment 370949 [details]
Patch
Comment 2 Wenson Hsieh 2019-05-30 10:24:02 PDT
Could you double check that this doesn't break phone number data detection in Mail display?
Comment 3 zalan 2019-05-30 10:36:26 PDT
(In reply to Wenson Hsieh from comment #2)
> Could you double check that this doesn't break phone number data detection
> in Mail display?
Should be fine as long as the content is not wrapped inside an <a> element.
Comment 4 Wenson Hsieh 2019-05-30 10:36:57 PDT
(In reply to zalan from comment #3)
> (In reply to Wenson Hsieh from comment #2)
> > Could you double check that this doesn't break phone number data detection
> > in Mail display?
> Should be fine as long as the content is not wrapped inside an <a> element.

👍🏻
Comment 5 zalan 2019-05-30 10:43:03 PDT
Apparently linkifying is off by default even on iOS (testing).
Comment 6 zalan 2019-05-30 11:05:57 PDT
Created attachment 370957 [details]
Patch
Comment 7 WebKit Commit Bot 2019-05-30 12:41:59 PDT
Comment on attachment 370957 [details]
Patch

Clearing flags on attachment: 370957

Committed r245900: <https://trac.webkit.org/changeset/245900>
Comment 8 WebKit Commit Bot 2019-05-30 12:42:01 PDT
All reviewed patches have been landed.  Closing bug.