Bug 198142 - webkitpy: Using sudo on iOS device during timeout spindumps
Summary: webkitpy: Using sudo on iOS device during timeout spindumps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-22 15:04 PDT by David Xiong
Modified: 2019-05-28 12:07 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.36 KB, patch)
2019-05-22 15:24 PDT, David Xiong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Xiong 2019-05-22 15:04:48 PDT
sample_process checks the source host instead of the target host when deciding whether or not to run sudo for spindumps.
Comment 1 David Xiong 2019-05-22 15:24:23 PDT
Created attachment 370451 [details]
Patch
Comment 2 WebKit Commit Bot 2019-05-28 12:06:24 PDT
Comment on attachment 370451 [details]
Patch

Clearing flags on attachment: 370451

Committed r245819: <https://trac.webkit.org/changeset/245819>
Comment 3 WebKit Commit Bot 2019-05-28 12:06:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-05-28 12:07:16 PDT
<rdar://problem/51188689>