Bug 198132 - [Paste] Add support for preferred presentation size when pasting an image
Summary: [Paste] Add support for preferred presentation size when pasting an image
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-22 10:55 PDT by zalan
Modified: 2019-05-22 12:13 PDT (History)
7 users (show)

See Also:


Attachments
Patch (19.38 KB, patch)
2019-05-22 11:05 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (20.15 KB, patch)
2019-05-22 11:48 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-05-22 10:55:50 PDT
<rdar://problem/50886917>
Comment 1 zalan 2019-05-22 11:05:36 PDT
Created attachment 370425 [details]
Patch
Comment 2 Wenson Hsieh 2019-05-22 11:12:43 PDT
Comment on attachment 370425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370425&action=review

r=mews

> Source/WebCore/platform/ios/PasteboardIOS.mm:184
> +Pasteboard::ReaderResult Pasteboard::readPasteboardWebContentDataForType(PasteboardWebContentReader& reader, PasteboardStrategy& strategy, NSString *type, PasteboardItemInfo itemInfo, int itemIndex)

Is there a reason you opted for PasteboardItemInfo over const PasteboardItemInfo& here?
Comment 3 zalan 2019-05-22 11:48:30 PDT
Created attachment 370431 [details]
Patch
Comment 4 WebKit Commit Bot 2019-05-22 12:13:41 PDT
Comment on attachment 370431 [details]
Patch

Clearing flags on attachment: 370431

Committed r245637: <https://trac.webkit.org/changeset/245637>
Comment 5 WebKit Commit Bot 2019-05-22 12:13:42 PDT
All reviewed patches have been landed.  Closing bug.