WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
19778
[Gtk] Initialize webview settings before running DRT tests
https://bugs.webkit.org/show_bug.cgi?id=19778
Summary
[Gtk] Initialize webview settings before running DRT tests
Jan Alonzo
Reported
2008-06-26 06:15:16 PDT
We need to initialize WebView settings before running the tests as some tests depend on font family, sizes, etc...
Attachments
Initialize webView settings before running test
(1.36 KB, patch)
2008-06-26 06:17 PDT
,
Jan Alonzo
christian
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jan Alonzo
Comment 1
2008-06-26 06:17:29 PDT
Created
attachment 21946
[details]
Initialize webView settings before running test This matches some of Mac's font settings. Is there anything else I'm missing? (apart from the ones that are not yet implemented)
Christian Dywan
Comment 2
2008-06-27 10:52:03 PDT
Comment on
attachment 21946
[details]
Initialize webView settings before running test
>+ g_object_set(G_OBJECT(settings), >+ "default-font-family", "Times", >+ "monospace-font-family", "Courier", >+ "serif-font-family", "Times", >+ "sans-serif-font-family", "Helvetica", >+ "default-font-size", 16, >+ "default-monospace-font-size", 13, >+ "minimum-font-size", 1, >+ NULL);
This looks fine to me.
> This matches some of Mac's font settings. Is there anything else I'm missing?
You might also disable the back forward list via webkit_web_view_set_maintains_back_forward_list. According to a comment in the mac port leaving it enabled, which is the case by default, can cause layout bugs.
Jan Alonzo
Comment 3
2008-06-27 15:27:57 PDT
Thanks. Landed in
r34837
. The backforward patch will be a different patch.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug