Bug 197771 - [Flatpak] Use the safe PyYAML loader if available
Summary: [Flatpak] Use the safe PyYAML loader if available
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-10 06:39 PDT by Adrian Perez
Modified: 2019-05-10 07:43 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.46 KB, patch)
2019-05-10 06:42 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2019-05-10 06:39:32 PDT 
Current versions of PyYAML give the following warning:

  /home/aperez/devel/WebKit/Tools/flatpak/flatpakutils.py:159: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.                                                    
    manifest = yaml.load(contents)                                    

Let's fix this and use “yaml.safe_load()” whenever it's available.
Comment 1 Adrian Perez 2019-05-10 06:42:21 PDT 
Created attachment 369551 [details]
Patch
Comment 2 WebKit Commit Bot 2019-05-10 07:42:33 PDT 
Comment on attachment 369551 [details]
Patch

Clearing flags on attachment: 369551

Committed r245172: <https://trac.webkit.org/changeset/245172>
Comment 3 WebKit Commit Bot 2019-05-10 07:42:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-05-10 07:43:21 PDT 
<rdar://problem/50662814>