Bug 197681 – WEBCORE_EXPORT shouldn't be on the class and its methods

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Don Olmstead]

ScrollingTreeFrameScrollingNode and ScrollingTreeScrollingNode have WEBCORE_EXPORT on the class and on some of its methods.

[Don Olmstead]

Created attachment 369341 [details]
Patch

[EWS Watchlist]

Attachment 369341 [details] did not pass style-queue:


ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:107:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:108:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 369341 [details]
Patch

Attachment 369341 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12129517

New failing tests:
security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star.html

[EWS Watchlist]

Created attachment 369353 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Frédéric Wang (:fredw)]

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.

So it looks these functions shouldn't have been inline or that WEBCORE_EXPORT shouldn't have been on the class.

@smfr: An idea?

[Simon Fraser (smfr)]

I've taken to just ignoring these warnings.

[Don Olmstead]

Comment on attachment 369341 [details]
Patch

Then r+?

[WebKit Commit Bot]

Comment on attachment 369341 [details]
Patch

Clearing flags on attachment: 369341

Committed r245066: <https://trac.webkit.org/changeset/245066>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50594144>