Created attachment 368898 [details] [Image] Bug Borders between the 2nd level sections are currently darker than the background.
Created attachment 368899 [details] Patch
Created attachment 368900 [details] [Image] With patch applied
Comment on attachment 368899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368899&action=review r=me > Source/WebInspectorUI/UserInterface/Views/DetailsSection.css:34 > + border-color: var(--text-color-quaternary); Hmm, having a "border-color" be a --text-color blows my mind but it seems like something we do _a lot_.
(In reply to Joseph Pecoraro from comment #3) > Comment on attachment 368899 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=368899&action=review > > r=me > > > Source/WebInspectorUI/UserInterface/Views/DetailsSection.css:34 > > + border-color: var(--text-color-quaternary); > > Hmm, having a "border-color" be a --text-color blows my mind but it seems > like something we do _a lot_. In Apple Human Interface Guidelines it's labelColor: https://developer.apple.com/design/human-interface-guidelines/macos/visual-design/color/#dynamic-system-colors I personally like "color" since in CSS text color is just "color": --color-primary --color-secondary --color-tertiary ...
Comment on attachment 368899 [details] Patch Clearing flags on attachment: 368899 Committed r244902: <https://trac.webkit.org/changeset/244902>
All reviewed patches have been landed. Closing bug.
<rdar://problem/50434984>