Bug 197551 - Web Inspector: Dark Mode: borders between section should be lighter than background
Summary: Web Inspector: Dark Mode: borders between section should be lighter than back...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-02 22:38 PDT by Nikita Vasilyev
Modified: 2019-05-02 23:18 PDT (History)
4 users (show)

See Also:


Attachments
[Image] Bug (19.64 KB, image/png)
2019-05-02 22:38 PDT, Nikita Vasilyev
no flags Details
Patch (1.21 KB, patch)
2019-05-02 22:39 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
[Image] With patch applied (22.30 KB, image/png)
2019-05-02 22:41 PDT, Nikita Vasilyev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2019-05-02 22:38:02 PDT
Created attachment 368898 [details]
[Image] Bug

Borders between the 2nd level sections are currently darker than the background.
Comment 1 Nikita Vasilyev 2019-05-02 22:39:01 PDT
Created attachment 368899 [details]
Patch
Comment 2 Nikita Vasilyev 2019-05-02 22:41:31 PDT
Created attachment 368900 [details]
[Image] With patch applied
Comment 3 Joseph Pecoraro 2019-05-02 22:50:12 PDT
Comment on attachment 368899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368899&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DetailsSection.css:34
> +    border-color: var(--text-color-quaternary);

Hmm, having a "border-color" be a --text-color blows my mind but it seems like something we do _a lot_.
Comment 4 Nikita Vasilyev 2019-05-02 22:55:39 PDT
(In reply to Joseph Pecoraro from comment #3)
> Comment on attachment 368899 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=368899&action=review
> 
> r=me
> 
> > Source/WebInspectorUI/UserInterface/Views/DetailsSection.css:34
> > +    border-color: var(--text-color-quaternary);
> 
> Hmm, having a "border-color" be a --text-color blows my mind but it seems
> like something we do _a lot_.

In Apple Human Interface Guidelines it's labelColor:  https://developer.apple.com/design/human-interface-guidelines/macos/visual-design/color/#dynamic-system-colors

I personally like "color" since in CSS text color is just "color":
--color-primary
--color-secondary
--color-tertiary
...
Comment 5 WebKit Commit Bot 2019-05-02 23:17:15 PDT
Comment on attachment 368899 [details]
Patch

Clearing flags on attachment: 368899

Committed r244902: <https://trac.webkit.org/changeset/244902>
Comment 6 WebKit Commit Bot 2019-05-02 23:17:16 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-05-02 23:18:18 PDT
<rdar://problem/50434984>