RESOLVED FIXED 197551
Web Inspector: Dark Mode: borders between section should be lighter than background
https://bugs.webkit.org/show_bug.cgi?id=197551
Summary Web Inspector: Dark Mode: borders between section should be lighter than back...
Nikita Vasilyev
Reported 2019-05-02 22:38:02 PDT
Created attachment 368898 [details] [Image] Bug Borders between the 2nd level sections are currently darker than the background.
Attachments
[Image] Bug (19.64 KB, image/png)
2019-05-02 22:38 PDT, Nikita Vasilyev
no flags
Patch (1.21 KB, patch)
2019-05-02 22:39 PDT, Nikita Vasilyev
no flags
[Image] With patch applied (22.30 KB, image/png)
2019-05-02 22:41 PDT, Nikita Vasilyev
no flags
Nikita Vasilyev
Comment 1 2019-05-02 22:39:01 PDT
Nikita Vasilyev
Comment 2 2019-05-02 22:41:31 PDT
Created attachment 368900 [details] [Image] With patch applied
Joseph Pecoraro
Comment 3 2019-05-02 22:50:12 PDT
Comment on attachment 368899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368899&action=review r=me > Source/WebInspectorUI/UserInterface/Views/DetailsSection.css:34 > + border-color: var(--text-color-quaternary); Hmm, having a "border-color" be a --text-color blows my mind but it seems like something we do _a lot_.
Nikita Vasilyev
Comment 4 2019-05-02 22:55:39 PDT
(In reply to Joseph Pecoraro from comment #3) > Comment on attachment 368899 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=368899&action=review > > r=me > > > Source/WebInspectorUI/UserInterface/Views/DetailsSection.css:34 > > + border-color: var(--text-color-quaternary); > > Hmm, having a "border-color" be a --text-color blows my mind but it seems > like something we do _a lot_. In Apple Human Interface Guidelines it's labelColor: https://developer.apple.com/design/human-interface-guidelines/macos/visual-design/color/#dynamic-system-colors I personally like "color" since in CSS text color is just "color": --color-primary --color-secondary --color-tertiary ...
WebKit Commit Bot
Comment 5 2019-05-02 23:17:15 PDT
Comment on attachment 368899 [details] Patch Clearing flags on attachment: 368899 Committed r244902: <https://trac.webkit.org/changeset/244902>
WebKit Commit Bot
Comment 6 2019-05-02 23:17:16 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-05-02 23:18:18 PDT
Note You need to log in before you can comment on or make changes to this bug.