197541 – Web Inspector: Elements: context menu items in DOM tree should work when not clicking directly on the node representation

RESOLVED FIXED 197541

Web Inspector: Elements: context menu items in DOM tree should work when not clicking directly on the node representation

https://bugs.webkit.org/show_bug.cgi?id=197541

Summary Web Inspector: Elements: context menu items in DOM tree should work when not ...

Devin Rousso

Reported 2019-05-02 18:38:43 PDT

I should be able to edit as HTML or set pseudo-classes by context menu clicking anywhere on any line.

Attachments
Patch (13.41 KB, patch) 2019-05-02 19:16 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews215 for win-future (13.72 MB, application/zip) 2019-05-02 20:53 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-05-02 19:16:25 PDT

Created attachment 368869 [details] Patch

EWS Watchlist

Comment 2 2019-05-02 20:52:59 PDT Comment hidden (obsolete)

Comment on attachment 368869 [details] Patch Attachment 368869 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12074512 New failing tests: svg/repaint/remove-border-property-on-root.html svg/repaint/remove-background-property-on-root.html svg/repaint/change-background-color.html svg/repaint/add-border-property-on-root.html

EWS Watchlist

Comment 3 2019-05-02 20:53:01 PDT Comment hidden (obsolete)

Created attachment 368885 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

WebKit Commit Bot

Comment 4 2019-05-17 21:44:39 PDT

Comment on attachment 368869 [details] Patch Clearing flags on attachment: 368869 Committed r245495: <https://trac.webkit.org/changeset/245495>

WebKit Commit Bot

Comment 5 2019-05-17 21:44:41 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2019-05-17 21:48:53 PDT

<rdar://problem/50914338>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware All

OS All

Product WebKit

Component Web Inspector

Assignee

Devin Rousso

Reported

2019-05-02 18:38 PDT

Modified

2019-05-17 21:48 PDT History

CC List

6 users Show

URL

Keywords InRadar

Depends on

Blocks