Bug 197534 - Unify UIKitSPI.h
Summary: Unify UIKitSPI.h
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-02 15:41 PDT by Alex Christensen
Modified: 2019-05-04 21:32 PDT (History)
5 users (show)

See Also:

Attachments
Patch (145.48 KB, patch)
2019-05-02 15:43 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (145.62 KB, patch)
2019-05-02 15:48 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (145.76 KB, patch)
2019-05-02 15:51 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (148.17 KB, patch)
2019-05-02 16:11 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (150.71 KB, patch)
2019-05-02 16:25 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (154.60 KB, patch)
2019-05-02 16:47 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (154.30 KB, patch)
2019-05-02 17:02 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (157.25 KB, patch)
2019-05-02 17:12 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (157.54 KB, patch)
2019-05-02 17:21 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (158.93 KB, patch)
2019-05-02 17:34 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (158.95 KB, patch)
2019-05-02 17:52 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (159.11 KB, patch)
2019-05-02 18:15 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (160.27 KB, patch)
2019-05-02 18:32 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (160.36 KB, patch)
2019-05-02 18:47 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (160.51 KB, patch)
2019-05-02 19:30 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (160.71 KB, patch)
2019-05-02 20:23 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (160.74 KB, patch)
2019-05-02 20:32 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (160.88 KB, patch)
2019-05-02 20:42 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (162.95 KB, patch)
2019-05-02 21:21 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (163.17 KB, patch)
2019-05-02 21:27 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (163.29 KB, patch)
2019-05-02 21:36 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (165.09 KB, patch)
2019-05-02 21:53 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (166.42 KB, patch)
2019-05-02 22:25 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (166.81 KB, patch)
2019-05-02 22:42 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (168.09 KB, patch)
2019-05-02 22:50 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (168.05 KB, patch)
2019-05-02 23:04 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (168.77 KB, patch)
2019-05-02 23:12 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews213 for win-future (13.82 MB, application/zip)
2019-05-03 00:40 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews112 for mac-highsierra (3.24 MB, application/zip)
2019-05-03 01:02 PDT, EWS Watchlist 		no flags Details
Patch (168.53 KB, patch)
2019-05-03 08:06 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (168.75 KB, patch)
2019-05-03 09:17 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (169.09 KB, patch)
2019-05-03 09:40 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (169.54 KB, patch)
2019-05-03 10:07 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (169.48 KB, patch)
2019-05-03 10:38 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (171.32 KB, patch)
2019-05-03 10:46 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (171.50 KB, patch)
2019-05-03 10:52 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (171.91 KB, patch)
2019-05-03 11:03 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (172.22 KB, patch)
2019-05-03 11:46 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (172.87 KB, patch)
2019-05-03 13:15 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
patch (172.87 KB, patch)
2019-05-03 13:32 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (172.85 KB, patch)
2019-05-03 14:03 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (172.86 KB, patch)
2019-05-03 14:16 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (174.53 KB, patch)
2019-05-03 14:38 PDT, Alex Christensen 		darin: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (13.49 MB, application/zip)
2019-05-03 16:58 PDT, EWS Watchlist 		no flags Details
Show Obsolete (42) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-05-02 15:41:27 PDT 
Unify UIKitSPI.h
Comment 1 Alex Christensen 2019-05-02 15:43:23 PDT 
Created attachment 368829 [details]
Patch
Comment 2 EWS Watchlist 2019-05-02 15:45:05 PDT 
Attachment 368829 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:47:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:476:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 2 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2019-05-02 15:48:35 PDT 
Created attachment 368831 [details]
Patch
Comment 4 Alex Christensen 2019-05-02 15:51:10 PDT 
Created attachment 368833 [details]
Patch
Comment 5 EWS Watchlist 2019-05-02 15:53:46 PDT 
Attachment 368833 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:487:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Alex Christensen 2019-05-02 16:11:46 PDT 
Created attachment 368837 [details]
Patch
Comment 7 EWS Watchlist 2019-05-02 16:14:51 PDT 
Attachment 368837 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:554:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Alex Christensen 2019-05-02 16:25:48 PDT 
Created attachment 368840 [details]
Patch
Comment 9 EWS Watchlist 2019-05-02 16:30:31 PDT 
Attachment 368840 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:599:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Alex Christensen 2019-05-02 16:47:23 PDT 
Created attachment 368846 [details]
Patch
Comment 11 Daniel Bates 2019-05-02 16:49:12 PDT 
 I would have done this change a long, long time again, but I resisted (and so did others) because I don’t want to give people in WebCore the impression that they can call UIKit. They shouldn’t in the Modern world. My dream and I think other people that I talked to was to reduce and remove the UIKitSPI header from PAL. UIKit SPI should only be used in WebKit in the Modern world. We just need it in webCore for legacy stuff
Comment 12 EWS Watchlist 2019-05-02 16:51:02 PDT 
Attachment 368846 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:722:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Alex Christensen 2019-05-02 17:01:28 PDT 
(In reply to Daniel Bates from comment #11)
I agree it should eventually be in WebKit, but for now I need it to be in one header.  We can move that one header later.
Comment 14 Alex Christensen 2019-05-02 17:02:09 PDT 
Created attachment 368847 [details]
Patch
Comment 15 EWS Watchlist 2019-05-02 17:04:18 PDT 
Attachment 368847 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:716:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 16 Alex Christensen 2019-05-02 17:12:47 PDT 
Created attachment 368848 [details]
Patch
Comment 17 EWS Watchlist 2019-05-02 17:14:31 PDT 
Attachment 368848 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:781:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 18 Alex Christensen 2019-05-02 17:21:22 PDT 
Created attachment 368849 [details]
Patch
Comment 19 EWS Watchlist 2019-05-02 17:23:48 PDT 
Attachment 368849 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:788:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 20 Alex Christensen 2019-05-02 17:34:29 PDT 
Created attachment 368851 [details]
Patch
Comment 21 EWS Watchlist 2019-05-02 17:37:08 PDT 
Attachment 368851 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:820:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 22 Alex Christensen 2019-05-02 17:52:19 PDT 
Created attachment 368854 [details]
Patch
Comment 23 EWS Watchlist 2019-05-02 17:55:44 PDT 
Attachment 368854 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:821:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 24 Alex Christensen 2019-05-02 18:15:57 PDT 
Created attachment 368859 [details]
Patch
Comment 25 EWS Watchlist 2019-05-02 18:18:52 PDT 
Attachment 368859 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:827:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 26 Alex Christensen 2019-05-02 18:32:37 PDT 
Created attachment 368862 [details]
Patch
Comment 27 EWS Watchlist 2019-05-02 18:36:02 PDT 
Attachment 368862 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:848:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 28 Alex Christensen 2019-05-02 18:47:24 PDT 
Created attachment 368864 [details]
Patch
Comment 29 EWS Watchlist 2019-05-02 18:49:10 PDT 
Attachment 368864 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:849:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 30 Alex Christensen 2019-05-02 19:30:34 PDT 
Created attachment 368871 [details]
Patch
Comment 31 EWS Watchlist 2019-05-02 19:32:45 PDT 
Attachment 368871 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:853:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 32 Alex Christensen 2019-05-02 20:23:31 PDT 
Created attachment 368880 [details]
Patch
Comment 33 EWS Watchlist 2019-05-02 20:26:09 PDT 
Attachment 368880 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:859:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 34 Alex Christensen 2019-05-02 20:32:06 PDT 
Created attachment 368881 [details]
Patch
Comment 35 EWS Watchlist 2019-05-02 20:36:26 PDT 
Attachment 368881 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:861:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 36 Alex Christensen 2019-05-02 20:42:37 PDT 
Created attachment 368883 [details]
Patch
Comment 37 EWS Watchlist 2019-05-02 20:44:49 PDT 
Attachment 368883 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:868:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 38 Daniel Bates 2019-05-02 21:12:48 PDT 
(In reply to Alex Christensen from comment #13)
> (In reply to Daniel Bates from comment #11)
> I agree it should eventually be in WebKit, but for now I need it to be in
> one header.  We can move that one header later.

Why?
Comment 39 Alex Christensen 2019-05-02 21:21:34 PDT 
Created attachment 368891 [details]
Patch
Comment 40 EWS Watchlist 2019-05-02 21:24:46 PDT 
Attachment 368891 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:874:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 41 Alex Christensen 2019-05-02 21:27:45 PDT 
Created attachment 368892 [details]
Patch
Comment 42 EWS Watchlist 2019-05-02 21:30:14 PDT 
Attachment 368892 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:874:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 43 Alex Christensen 2019-05-02 21:36:54 PDT 
Created attachment 368893 [details]
Patch
Comment 44 EWS Watchlist 2019-05-02 21:38:32 PDT 
Attachment 368893 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:875:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 45 Alex Christensen 2019-05-02 21:53:02 PDT 
Created attachment 368895 [details]
Patch
Comment 46 EWS Watchlist 2019-05-02 21:54:48 PDT 
Attachment 368895 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:897:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 47 Alex Christensen 2019-05-02 22:25:19 PDT 
Created attachment 368897 [details]
Patch
Comment 48 EWS Watchlist 2019-05-02 22:27:20 PDT 
Attachment 368897 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:923:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 49 Alex Christensen 2019-05-02 22:37:09 PDT 
(In reply to Daniel Bates from comment #38)
> (In reply to Alex Christensen from comment #13)
> > (In reply to Daniel Bates from comment #11)
> > I agree it should eventually be in WebKit, but for now I need it to be in
> > one header.  We can move that one header later.
> 
> Why?

This is blocking https://bugs.webkit.org/show_bug.cgi?id=197397
Comment 50 Alex Christensen 2019-05-02 22:42:36 PDT 
Created attachment 368901 [details]
Patch
Comment 51 EWS Watchlist 2019-05-02 22:45:14 PDT 
Attachment 368901 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:950:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 52 Daniel Bates 2019-05-02 22:46:27 PDT 
(In reply to Alex Christensen from comment #49)
> (In reply to Daniel Bates from comment #38)
> > (In reply to Alex Christensen from comment #13)
> > > (In reply to Daniel Bates from comment #11)
> > > I agree it should eventually be in WebKit, but for now I need it to be in
> > > one header.  We can move that one header later.
> > 
> > Why?
> 
> This is blocking https://bugs.webkit.org/show_bug.cgi?id=197397

Can you please explain why? It does not make sense to me why this unification is the absolutely necessary to fix your issue.
Comment 53 Alex Christensen 2019-05-02 22:50:37 PDT 
Created attachment 368902 [details]
Patch
Comment 54 EWS Watchlist 2019-05-02 22:53:36 PDT 
Attachment 368902 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:988:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 55 Alex Christensen 2019-05-02 23:01:17 PDT 
In that bug, I added a file, which made files which include different versions of UIKitSPI.h clash.  I tried to fix the clash, but after discussing with a few people I decided that the best way to proceed was to clean up our SPI header mess so there will be no more duplicate declaration or header including confusion in the future.  The fact that WebCore does not link UIKit is sufficient to prevent people from adding more UIKit use in WebCore without soft linking it.
Comment 56 Alex Christensen 2019-05-02 23:04:26 PDT 
Created attachment 368903 [details]
Patch
Comment 57 EWS Watchlist 2019-05-02 23:07:00 PDT 
Attachment 368903 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:985:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 58 Alex Christensen 2019-05-02 23:12:48 PDT 
Created attachment 368905 [details]
Patch
Comment 59 EWS Watchlist 2019-05-02 23:15:14 PDT 
Attachment 368905 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1010:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 60 EWS Watchlist 2019-05-03 00:40:32 PDT 
Comment on attachment 368905 [details]
Patch

Attachment 368905 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12080107

New failing tests:
security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star.html
Comment 61 EWS Watchlist 2019-05-03 00:40:35 PDT 
Created attachment 368910 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 62 EWS Watchlist 2019-05-03 01:01:58 PDT 
Comment on attachment 368905 [details]
Patch

Attachment 368905 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12080192

New failing tests:
media/W3C/video/events/event_progress.html
Comment 63 EWS Watchlist 2019-05-03 01:02:00 PDT 
Created attachment 368911 [details]
Archive of layout-test-results from ews112 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 64 Alex Christensen 2019-05-03 08:06:28 PDT 
Created attachment 368927 [details]
Patch
Comment 65 EWS Watchlist 2019-05-03 08:08:15 PDT 
Attachment 368927 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1001:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 66 Alex Christensen 2019-05-03 09:17:26 PDT 
Created attachment 368933 [details]
Patch
Comment 67 EWS Watchlist 2019-05-03 09:20:35 PDT 
Attachment 368933 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1009:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 68 Alex Christensen 2019-05-03 09:40:06 PDT 
Created attachment 368938 [details]
Patch
Comment 69 EWS Watchlist 2019-05-03 09:43:07 PDT 
Attachment 368938 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1014:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 70 Alex Christensen 2019-05-03 10:07:05 PDT 
Created attachment 368943 [details]
Patch
Comment 71 EWS Watchlist 2019-05-03 10:10:18 PDT 
Attachment 368943 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1030:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 72 Alex Christensen 2019-05-03 10:38:47 PDT 
Created attachment 368948 [details]
Patch
Comment 73 EWS Watchlist 2019-05-03 10:41:34 PDT 
Attachment 368948 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1027:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 74 Alex Christensen 2019-05-03 10:46:26 PDT 
Created attachment 368949 [details]
Patch
Comment 75 EWS Watchlist 2019-05-03 10:48:59 PDT 
Attachment 368949 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1079:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 76 Alex Christensen 2019-05-03 10:52:02 PDT 
Created attachment 368950 [details]
Patch
Comment 77 EWS Watchlist 2019-05-03 10:55:14 PDT 
Attachment 368950 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1085:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 78 Alex Christensen 2019-05-03 11:03:45 PDT 
Created attachment 368951 [details]
Patch
Comment 79 EWS Watchlist 2019-05-03 11:06:45 PDT 
Attachment 368951 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1098:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 80 Alex Christensen 2019-05-03 11:46:43 PDT 
Created attachment 368958 [details]
Patch
Comment 81 EWS Watchlist 2019-05-03 11:51:24 PDT 
Attachment 368958 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1105:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 82 Alex Christensen 2019-05-03 13:15:02 PDT 
Created attachment 368974 [details]
Patch
Comment 83 EWS Watchlist 2019-05-03 13:18:22 PDT 
Attachment 368974 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1125:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 84 Alex Christensen 2019-05-03 13:32:01 PDT 
Created attachment 368975 [details]
patch
Comment 85 Alex Christensen 2019-05-03 14:03:34 PDT 
Created attachment 368984 [details]
Patch
Comment 86 EWS Watchlist 2019-05-03 14:06:33 PDT 
Attachment 368984 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1124:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 87 Alex Christensen 2019-05-03 14:16:19 PDT 
Created attachment 368986 [details]
Patch
Comment 88 EWS Watchlist 2019-05-03 14:19:52 PDT 
Attachment 368986 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1130:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 89 Alex Christensen 2019-05-03 14:38:00 PDT 
Created attachment 368992 [details]
Patch
Comment 90 EWS Watchlist 2019-05-03 14:41:13 PDT 
Attachment 368992 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1159:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 91 Darin Adler 2019-05-03 15:47:30 PDT 
Small idea for refinement of the title to this bug: I think there are three different UIKitSPI.h headers before, and we are merging the two of them outside PAL into the PAL one here. Is that right? If so, I think for clarity I would have titled this bug "Merge the three UIKitSPI.h files into a single one in PAL".

I was trying to figure out what the unification entailed, and I think it’s just merging. Is there more to it?
Comment 92 EWS Watchlist 2019-05-03 16:58:06 PDT 
Comment on attachment 368992 [details]
Patch

Attachment 368992 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12093233

New failing tests:
svg/repaint/remove-border-property-on-root.html
svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html
Comment 93 EWS Watchlist 2019-05-03 16:58:09 PDT 
Created attachment 369024 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 94 Alex Christensen 2019-05-04 20:02:10 PDT 
http://trac.webkit.org/r244953
Comment 95 Radar WebKit Bug Importer 2019-05-04 20:05:21 PDT 
<rdar://problem/50476279>
Comment 96 Alex Christensen 2019-05-04 20:29:29 PDT 
http://trac.webkit.org/r244954
Comment 97 Alex Christensen 2019-05-04 21:32:18 PDT 
http://trac.webkit.org/r244955

Well that was fun :(