Bug 197534 – Unify UIKitSPI.h

• Status: REOPENED
• Component: New Bugs

[Alex Christensen]

Unify UIKitSPI.h

[Alex Christensen]

Created attachment 368829 [details]
Patch

[EWS Watchlist]

Attachment 368829 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:47:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:476:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 2 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368831 [details]
Patch

[Alex Christensen]

Created attachment 368833 [details]
Patch

[EWS Watchlist]

Attachment 368833 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:487:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368837 [details]
Patch

[EWS Watchlist]

Attachment 368837 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:554:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368840 [details]
Patch

[EWS Watchlist]

Attachment 368840 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:599:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368846 [details]
Patch

[Daniel Bates]

 I would have done this change a long, long time again, but I resisted (and so did others) because I don’t want to give people in WebCore the impression that they can call UIKit. They shouldn’t in the Modern world. My dream and I think other people that I talked to was to reduce and remove the UIKitSPI header from PAL. UIKit SPI should only be used in WebKit in the Modern world. We just need it in webCore for legacy stuff

[EWS Watchlist]

Attachment 368846 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:722:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

(In reply to Daniel Bates from comment #11)
I agree it should eventually be in WebKit, but for now I need it to be in one header.  We can move that one header later.

[Alex Christensen]

Created attachment 368847 [details]
Patch

[EWS Watchlist]

Attachment 368847 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:716:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368848 [details]
Patch

[EWS Watchlist]

Attachment 368848 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:781:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368849 [details]
Patch

[EWS Watchlist]

Attachment 368849 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:788:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368851 [details]
Patch

[EWS Watchlist]

Attachment 368851 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:820:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368854 [details]
Patch

[EWS Watchlist]

Attachment 368854 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:821:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368859 [details]
Patch

[EWS Watchlist]

Attachment 368859 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:827:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368862 [details]
Patch

[EWS Watchlist]

Attachment 368862 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:848:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368864 [details]
Patch

[EWS Watchlist]

Attachment 368864 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:849:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368871 [details]
Patch

[EWS Watchlist]

Attachment 368871 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:853:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368880 [details]
Patch

[EWS Watchlist]

Attachment 368880 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:859:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368881 [details]
Patch

[EWS Watchlist]

Attachment 368881 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:861:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368883 [details]
Patch

[EWS Watchlist]

Attachment 368883 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:868:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

(In reply to Alex Christensen from comment #13)
> (In reply to Daniel Bates from comment #11)
> I agree it should eventually be in WebKit, but for now I need it to be in
> one header.  We can move that one header later.

Why?

[Alex Christensen]

Created attachment 368891 [details]
Patch

[EWS Watchlist]

Attachment 368891 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:874:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368892 [details]
Patch

[EWS Watchlist]

Attachment 368892 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:874:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368893 [details]
Patch

[EWS Watchlist]

Attachment 368893 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:875:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368895 [details]
Patch

[EWS Watchlist]

Attachment 368895 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:897:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368897 [details]
Patch

[EWS Watchlist]

Attachment 368897 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:923:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

(In reply to Daniel Bates from comment #38)
> (In reply to Alex Christensen from comment #13)
> > (In reply to Daniel Bates from comment #11)
> > I agree it should eventually be in WebKit, but for now I need it to be in
> > one header.  We can move that one header later.
> 
> Why?

This is blocking https://bugs.webkit.org/show_bug.cgi?id=197397

[Alex Christensen]

Created attachment 368901 [details]
Patch

[EWS Watchlist]

Attachment 368901 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:950:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

(In reply to Alex Christensen from comment #49)
> (In reply to Daniel Bates from comment #38)
> > (In reply to Alex Christensen from comment #13)
> > > (In reply to Daniel Bates from comment #11)
> > > I agree it should eventually be in WebKit, but for now I need it to be in
> > > one header.  We can move that one header later.
> > 
> > Why?
> 
> This is blocking https://bugs.webkit.org/show_bug.cgi?id=197397

Can you please explain why? It does not make sense to me why this unification is the absolutely necessary to fix your issue.

[Alex Christensen]

Created attachment 368902 [details]
Patch

[EWS Watchlist]

Attachment 368902 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:988:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

In that bug, I added a file, which made files which include different versions of UIKitSPI.h clash.  I tried to fix the clash, but after discussing with a few people I decided that the best way to proceed was to clean up our SPI header mess so there will be no more duplicate declaration or header including confusion in the future.  The fact that WebCore does not link UIKit is sufficient to prevent people from adding more UIKit use in WebCore without soft linking it.

[Alex Christensen]

Created attachment 368903 [details]
Patch

[EWS Watchlist]

Attachment 368903 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:985:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368905 [details]
Patch

[EWS Watchlist]

Attachment 368905 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1010:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 368905 [details]
Patch

Attachment 368905 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12080107

New failing tests:
security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star.html

[EWS Watchlist]

Created attachment 368910 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[EWS Watchlist]

Comment on attachment 368905 [details]
Patch

Attachment 368905 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12080192

New failing tests:
media/W3C/video/events/event_progress.html

[EWS Watchlist]

Created attachment 368911 [details]
Archive of layout-test-results from ews112 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Alex Christensen]

Created attachment 368927 [details]
Patch

[EWS Watchlist]

Attachment 368927 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1001:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368933 [details]
Patch

[EWS Watchlist]

Attachment 368933 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1009:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368938 [details]
Patch

[EWS Watchlist]

Attachment 368938 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1014:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368943 [details]
Patch

[EWS Watchlist]

Attachment 368943 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1030:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368948 [details]
Patch

[EWS Watchlist]

Attachment 368948 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1027:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368949 [details]
Patch

[EWS Watchlist]

Attachment 368949 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1079:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368950 [details]
Patch

[EWS Watchlist]

Attachment 368950 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1085:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368951 [details]
Patch

[EWS Watchlist]

Attachment 368951 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1098:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368958 [details]
Patch

[EWS Watchlist]

Attachment 368958 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1105:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368974 [details]
Patch

[EWS Watchlist]

Attachment 368974 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1125:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368975 [details]
patch

[Alex Christensen]

Created attachment 368984 [details]
Patch

[EWS Watchlist]

Attachment 368984 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1124:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368986 [details]
Patch

[EWS Watchlist]

Attachment 368986 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1130:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 368992 [details]
Patch

[EWS Watchlist]

Attachment 368992 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1159:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Small idea for refinement of the title to this bug: I think there are three different UIKitSPI.h headers before, and we are merging the two of them outside PAL into the PAL one here. Is that right? If so, I think for clarity I would have titled this bug "Merge the three UIKitSPI.h files into a single one in PAL".

I was trying to figure out what the unification entailed, and I think it’s just merging. Is there more to it?

[EWS Watchlist]

Comment on attachment 368992 [details]
Patch

Attachment 368992 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12093233

New failing tests:
svg/repaint/remove-border-property-on-root.html
svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html

[EWS Watchlist]

Created attachment 369024 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Alex Christensen]

http://trac.webkit.org/r244953

[Radar WebKit Bug Importer]

<rdar://problem/50476279>

[Alex Christensen]

http://trac.webkit.org/r244954

[Alex Christensen]

http://trac.webkit.org/r244955

Well that was fun :(