Unify UIKitSPI.h
Created attachment 368829 [details] Patch
Attachment 368829 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:47: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:476: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 2 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368831 [details] Patch
Created attachment 368833 [details] Patch
Attachment 368833 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:487: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368837 [details] Patch
Attachment 368837 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:554: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368840 [details] Patch
Attachment 368840 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:599: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368846 [details] Patch
I would have done this change a long, long time again, but I resisted (and so did others) because I donβt want to give people in WebCore the impression that they can call UIKit. They shouldnβt in the Modern world. My dream and I think other people that I talked to was to reduce and remove the UIKitSPI header from PAL. UIKit SPI should only be used in WebKit in the Modern world. We just need it in webCore for legacy stuff
Attachment 368846 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:722: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to Daniel Bates from comment #11) I agree it should eventually be in WebKit, but for now I need it to be in one header. We can move that one header later.
Created attachment 368847 [details] Patch
Attachment 368847 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:716: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368848 [details] Patch
Attachment 368848 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:781: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368849 [details] Patch
Attachment 368849 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:788: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368851 [details] Patch
Attachment 368851 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:820: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368854 [details] Patch
Attachment 368854 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:821: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368859 [details] Patch
Attachment 368859 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:827: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368862 [details] Patch
Attachment 368862 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:848: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368864 [details] Patch
Attachment 368864 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:849: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368871 [details] Patch
Attachment 368871 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:853: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368880 [details] Patch
Attachment 368880 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:859: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368881 [details] Patch
Attachment 368881 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:861: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368883 [details] Patch
Attachment 368883 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:868: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to Alex Christensen from comment #13) > (In reply to Daniel Bates from comment #11) > I agree it should eventually be in WebKit, but for now I need it to be in > one header. We can move that one header later. Why?
Created attachment 368891 [details] Patch
Attachment 368891 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:874: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368892 [details] Patch
Attachment 368892 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:874: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368893 [details] Patch
Attachment 368893 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:875: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368895 [details] Patch
Attachment 368895 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:897: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368897 [details] Patch
Attachment 368897 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:923: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to Daniel Bates from comment #38) > (In reply to Alex Christensen from comment #13) > > (In reply to Daniel Bates from comment #11) > > I agree it should eventually be in WebKit, but for now I need it to be in > > one header. We can move that one header later. > > Why? This is blocking https://bugs.webkit.org/show_bug.cgi?id=197397
Created attachment 368901 [details] Patch
Attachment 368901 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:950: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to Alex Christensen from comment #49) > (In reply to Daniel Bates from comment #38) > > (In reply to Alex Christensen from comment #13) > > > (In reply to Daniel Bates from comment #11) > > > I agree it should eventually be in WebKit, but for now I need it to be in > > > one header. We can move that one header later. > > > > Why? > > This is blocking https://bugs.webkit.org/show_bug.cgi?id=197397 Can you please explain why? It does not make sense to me why this unification is the absolutely necessary to fix your issue.
Created attachment 368902 [details] Patch
Attachment 368902 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:988: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
In that bug, I added a file, which made files which include different versions of UIKitSPI.h clash. I tried to fix the clash, but after discussing with a few people I decided that the best way to proceed was to clean up our SPI header mess so there will be no more duplicate declaration or header including confusion in the future. The fact that WebCore does not link UIKit is sufficient to prevent people from adding more UIKit use in WebCore without soft linking it.
Created attachment 368903 [details] Patch
Attachment 368903 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:985: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368905 [details] Patch
Attachment 368905 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1010: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 368905 [details] Patch Attachment 368905 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12080107 New failing tests: security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star.html
Created attachment 368910 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 368905 [details] Patch Attachment 368905 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12080192 New failing tests: media/W3C/video/events/event_progress.html
Created attachment 368911 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 368927 [details] Patch
Attachment 368927 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1001: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368933 [details] Patch
Attachment 368933 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1009: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368938 [details] Patch
Attachment 368938 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1014: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368943 [details] Patch
Attachment 368943 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1030: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368948 [details] Patch
Attachment 368948 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1027: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368949 [details] Patch
Attachment 368949 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1079: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368950 [details] Patch
Attachment 368950 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1085: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368951 [details] Patch
Attachment 368951 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1098: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368958 [details] Patch
Attachment 368958 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1105: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368974 [details] Patch
Attachment 368974 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1125: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368975 [details] patch
Created attachment 368984 [details] Patch
Attachment 368984 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1124: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368986 [details] Patch
Attachment 368986 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1130: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368992 [details] Patch
Attachment 368992 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:1159: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 100 files If any of these errors are false positives, please file a bug against check-webkit-style.
Small idea for refinement of the title to this bug: I think there are three different UIKitSPI.h headers before, and we are merging the two of them outside PAL into the PAL one here. Is that right? If so, I think for clarity I would have titled this bug "Merge the three UIKitSPI.h files into a single one in PAL". I was trying to figure out what the unification entailed, and I think itβs just merging. Is there more to it?
Comment on attachment 368992 [details] Patch Attachment 368992 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12093233 New failing tests: svg/repaint/remove-border-property-on-root.html svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html
Created attachment 369024 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
http://trac.webkit.org/r244953
<rdar://problem/50476279>
http://trac.webkit.org/r244954
http://trac.webkit.org/r244955 Well that was fun :(