Bug 197518 - [lldb-webkit] Support adding pretty-printing for qualified types
Summary: [lldb-webkit] Support adding pretty-printing for qualified types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-02 10:13 PDT by Daniel Bates
Modified: 2019-05-03 16:14 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.92 KB, patch)
2019-05-02 10:18 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews212 for win-future (13.42 MB, application/zip)
2019-05-02 15:43 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-05-02 10:13:39 PDT 
Support adding pretty-printing for qualified types (e.g. WebCore::MapCoordinatesFlags <-- yeah, we should convert this to a OptionSet).
Comment 1 Daniel Bates 2019-05-02 10:18:13 PDT 
Created attachment 368783 [details]
Patch
Comment 2 EWS Watchlist 2019-05-02 15:43:17 PDT 
Comment on attachment 368783 [details]
Patch

Attachment 368783 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12066263

New failing tests:
svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html
svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop.html
Comment 3 EWS Watchlist 2019-05-02 15:43:19 PDT 
Created attachment 368828 [details]
Archive of layout-test-results from ews212 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 4 Daniel Bates 2019-05-03 16:13:34 PDT 
Comment on attachment 368783 [details]
Patch

Clearing flags on attachment: 368783

Committed r244934: <https://trac.webkit.org/changeset/244934>
Comment 5 Daniel Bates 2019-05-03 16:13:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-05-03 16:14:24 PDT 
<rdar://problem/50461115>