Title 17A469: Hitpoint for link which spans two lines in web content is incorrect
Created attachment 368773 [details] Patch
<rdar://problem/49971483>
Comment on attachment 368773 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368773&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:910 > + /* Links bounding rect can contain points that are not part of the can we put this link stuff into a separate method? then we can just write if (isLink()) return linkClickPoint(); > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:912 > + finishes at the beginning of the next line will have a boundg rect boundg ->. bounding > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1603 > + IntPoint point = m_object->clickPoint(); auto point
Comment on attachment 368773 [details] Patch Attachment 368773 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12062726 New failing tests: accessibility/ios-simulator/links-activation.html
Created attachment 368785 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4
Comment on attachment 368773 [details] Patch Attachment 368773 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12064022 New failing tests: security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star.html
Created attachment 368810 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 368870 [details] Patch
Comment on attachment 368870 [details] Patch Attachment 368870 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12073397 New failing tests: accessibility/links-activation.html
Created attachment 368873 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368870 [details] Patch Attachment 368870 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12073621 New failing tests: accessibility/links-activation.html
Created attachment 368879 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 368870 [details] Patch Attachment 368870 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12074636 New failing tests: accessibility/links-activation.html
Created attachment 368887 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 368870 [details] Patch Attachment 368870 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12074320 New failing tests: accessibility/links-activation.html
Created attachment 368889 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368870 [details] Patch Attachment 368870 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12074925 New failing tests: accessibility/ios-simulator/links-activation.html
Created attachment 368894 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4
Comment on attachment 368870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368870&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=197511 Please update the bug title in accordance with my change. Also, there is no need in repeating the title again for radar. > Source/WebCore/ChangeLog:12 > + Reviewed by NOBODY (OOPS!). This line should appear before change descriptions but after URLs.
Created attachment 368923 [details] Patch
Comment on attachment 368923 [details] Patch Attachment 368923 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12088055 New failing tests: accessibility/links-activation.html
Created attachment 368928 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368923 [details] Patch Attachment 368923 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12088087 New failing tests: accessibility/links-activation.html
Created attachment 368930 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 368923 [details] Patch Attachment 368923 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12088103 New failing tests: accessibility/links-activation.html
Created attachment 368931 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 368923 [details] Patch Attachment 368923 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12088105 New failing tests: accessibility/links-activation.html
Created attachment 368934 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368923 [details] Patch Attachment 368923 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12088120 New failing tests: accessibility/ios-simulator/links-activation.html
Created attachment 368935 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4
Created attachment 368945 [details] Patch
Comment on attachment 368945 [details] Patch Attachment 368945 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12089420 New failing tests: accessibility/links-activation.html
Created attachment 368954 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368945 [details] Patch Attachment 368945 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12089407 New failing tests: accessibility/links-activation.html
Created attachment 368956 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Created attachment 368957 [details] Patch
Comment on attachment 368945 [details] Patch Attachment 368945 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12089580 New failing tests: accessibility/links-activation.html
Created attachment 368960 [details] Archive of layout-test-results from ews116 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368945 [details] Patch Attachment 368945 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12089835 New failing tests: accessibility/ios-simulator/links-activation.html
Created attachment 368963 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4
Comment on attachment 368945 [details] Patch Attachment 368945 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12090043 New failing tests: accessibility/links-activation.html
Created attachment 368964 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 368957 [details] Patch Attachment 368957 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12090271 New failing tests: accessibility/links-activation.html
Created attachment 368966 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368957 [details] Patch Attachment 368957 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12090287 New failing tests: accessibility/links-activation.html
Created attachment 368967 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 368957 [details] Patch Attachment 368957 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12090266 New failing tests: accessibility/links-activation.html
Created attachment 368971 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368957 [details] Patch Attachment 368957 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12090270 New failing tests: accessibility/ios-simulator/links-activation.html
Created attachment 368973 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4
Comment on attachment 368957 [details] Patch Attachment 368957 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12090797 New failing tests: accessibility/links-activation.html
Created attachment 368982 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 368993 [details] Patch
Comment on attachment 368993 [details] Patch Attachment 368993 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12092394 New failing tests: accessibility/links-activation.html
Created attachment 369006 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368993 [details] Patch Attachment 368993 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12092495 New failing tests: accessibility/links-activation.html
Created attachment 369008 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 368993 [details] Patch Attachment 368993 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12093168 New failing tests: accessibility/links-activation.html legacy-animation-engine/fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html
Created attachment 369019 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 368993 [details] Patch Attachment 368993 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12092844 New failing tests: accessibility/links-activation.html
Created attachment 369020 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368993 [details] Patch Attachment 368993 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12092865 New failing tests: accessibility/ios-simulator/links-activation.html
Created attachment 369022 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4
Created attachment 369097 [details] Patch
Comment on attachment 369097 [details] Patch Attachment 369097 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12109390 New failing tests: svg/repaint/remove-border-property-on-root.html
Created attachment 369114 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 369097 [details] Patch Clearing flags on attachment: 369097 Committed r244983: <https://trac.webkit.org/changeset/244983>
All reviewed patches have been landed. Closing bug.
The new test accessibility/links-activation.html added in https://trac.webkit.org/changeset/244983/webkit is a flakey failure on Mojave Debug WK2. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Flinks-activation.html Diff: --- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/accessibility/links-activation-expected.txt +++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/accessibility/links-activation-actual.txt @@ -11,8 +11,6 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -click event [object MouseEvent] for element A with id multiline-link -click event [object MouseEvent] for element A with id singleline-link PASS successfullyParsed is true TEST COMPLETE
Reopening to attach new patch.
Created attachment 370160 [details] Patch
Comment on attachment 370160 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370160&action=review > LayoutTests/accessibility/links-activation.html:47 > + }); looks like indentation is too much for these lines. should only be 4 char indentation
Created attachment 370162 [details] Patch
(In reply to chris fleizach from comment #72) > Comment on attachment 370160 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=370160&action=review > > > LayoutTests/accessibility/links-activation.html:47 > > + }); > > looks like indentation is too much for these lines. should only be 4 char > indentation That's Xcode default indentation, hard to fight all the time, but fixed in the new upload.
Comment on attachment 370162 [details] Patch Clearing flags on attachment: 370162 Committed r245518: <https://trac.webkit.org/changeset/245518>