Bug 197480 - Pass KeyboardEvent by reference in more places
Summary: Pass KeyboardEvent by reference in more places
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-01 15:04 PDT by Daniel Bates
Modified: 2019-05-03 16:06 PDT (History)
5 users (show)

See Also:

Attachments
Patch (26.98 KB, patch)
2019-05-01 15:21 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (28.08 KB, patch)
2019-05-02 11:07 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (14.10 MB, application/zip)
2019-05-02 13:50 PDT, EWS Watchlist 		no flags Details
To land (28.20 KB, patch)
2019-05-03 16:03 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-05-01 15:04:45 PDT 
Pass KeyboardEvent by reference in more places
Comment 1 Daniel Bates 2019-05-01 15:21:29 PDT 
Created attachment 368720 [details]
Patch
Comment 2 Daniel Bates 2019-05-01 15:22:54 PDT 
It is so tempting to do more KeyboardEvent* to KeyboardEvent& changes, but the full transitive closure is getting kinda big. Here's a patch towards fixing everything!
Comment 3 Wenson Hsieh 2019-05-01 15:25:35 PDT 
Comment on attachment 368720 [details]
Patch

r=mews
Comment 4 Daniel Bates 2019-05-02 11:07:33 PDT 
Created attachment 368787 [details]
Patch
Comment 5 EWS Watchlist 2019-05-02 13:50:27 PDT 
Comment on attachment 368787 [details]
Patch

Attachment 368787 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12064541

New failing tests:
svg/repaint/add-background-property-on-root.html
Comment 6 EWS Watchlist 2019-05-02 13:50:29 PDT 
Created attachment 368816 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 7 Daniel Bates 2019-05-03 16:03:00 PDT 
Created attachment 369010 [details]
To land
Comment 8 Daniel Bates 2019-05-03 16:04:15 PDT 
Committed r244932: <https://trac.webkit.org/changeset/244932>
Comment 9 Radar WebKit Bug Importer 2019-05-03 16:06:47 PDT 
<rdar://problem/50460850>