WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
197477
Add back hasNullReferences() assert in Document::updateIsPlayingMedia
https://bugs.webkit.org/show_bug.cgi?id=197477
Summary
Add back hasNullReferences() assert in Document::updateIsPlayingMedia
youenn fablet
Reported
2019-05-01 14:13:35 PDT
Add back hasNullReferences() assert in Document::updateIsPlayingMedia
Attachments
Patch
(3.46 KB, patch)
2019-05-01 16:08 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
2019-05-01 16:08:07 PDT
Created
attachment 368727
[details]
Patch
WebKit Commit Bot
Comment 2
2019-05-01 17:20:45 PDT
Comment on
attachment 368727
[details]
Patch Clearing flags on attachment: 368727 Committed
r244860
: <
https://trac.webkit.org/changeset/244860
>
WebKit Commit Bot
Comment 3
2019-05-01 17:20:46 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 4
2019-05-01 18:34:18 PDT
Comment on
attachment 368727
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=368727&action=review
> Source/WebCore/Modules/webaudio/AudioContext.cpp:1069 > ScriptExecutionContext* AudioContext::scriptExecutionContext() const > { > - return m_isStopScheduled ? 0 : ActiveDOMObject::scriptExecutionContext(); > + return ActiveDOMObject::scriptExecutionContext(); > }
Could we come back and just remove this override later?
youenn fablet
Comment 5
2019-05-01 19:34:52 PDT
(In reply to Darin Adler from
comment #4
)
> Comment on
attachment 368727
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=368727&action=review
> > > Source/WebCore/Modules/webaudio/AudioContext.cpp:1069 > > ScriptExecutionContext* AudioContext::scriptExecutionContext() const > > { > > - return m_isStopScheduled ? 0 : ActiveDOMObject::scriptExecutionContext(); > > + return ActiveDOMObject::scriptExecutionContext(); > > } > > Could we come back and just remove this override later?
Could you clarify your suggestion? This override is currently needed as AudioContext is an EventTarget.
Darin Adler
Comment 6
2019-05-02 14:33:37 PDT
Comment on
attachment 368727
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=368727&action=review
>>> Source/WebCore/Modules/webaudio/AudioContext.cpp:1069 >>> } >> >> Could we come back and just remove this override later? > > Could you clarify your suggestion? > This override is currently needed as AudioContext is an EventTarget.
OK, then we can’t remove it.
Radar WebKit Bug Importer
Comment 7
2019-05-02 15:35:28 PDT
<
rdar://problem/50424860
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug