Bug 197477 – Add back hasNullReferences() assert in Document::updateIsPlayingMedia

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[youenn fablet]

Add back hasNullReferences() assert in Document::updateIsPlayingMedia

[youenn fablet]

Created attachment 368727 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 368727 [details]
Patch

Clearing flags on attachment: 368727

Committed r244860: <https://trac.webkit.org/changeset/244860>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 368727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368727&action=review

> Source/WebCore/Modules/webaudio/AudioContext.cpp:1069
>  ScriptExecutionContext* AudioContext::scriptExecutionContext() const
>  {
> -    return m_isStopScheduled ? 0 : ActiveDOMObject::scriptExecutionContext();
> +    return ActiveDOMObject::scriptExecutionContext();
>  }

Could we come back and just remove this override later?

[youenn fablet]

(In reply to Darin Adler from comment #4)
> Comment on attachment 368727 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=368727&action=review
> 
> > Source/WebCore/Modules/webaudio/AudioContext.cpp:1069
> >  ScriptExecutionContext* AudioContext::scriptExecutionContext() const
> >  {
> > -    return m_isStopScheduled ? 0 : ActiveDOMObject::scriptExecutionContext();
> > +    return ActiveDOMObject::scriptExecutionContext();
> >  }
> 
> Could we come back and just remove this override later?

Could you clarify your suggestion?
This override is currently needed as AudioContext is an EventTarget.

[Darin Adler]

Comment on attachment 368727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368727&action=review

>>> Source/WebCore/Modules/webaudio/AudioContext.cpp:1069
>>>  }
>> 
>> Could we come back and just remove this override later?
> 
> Could you clarify your suggestion?
> This override is currently needed as AudioContext is an EventTarget.

OK, then we can’t remove it.

[Radar WebKit Bug Importer]

<rdar://problem/50424860>