Bug 197477 - Add back hasNullReferences() assert in Document::updateIsPlayingMedia
Summary: Add back hasNullReferences() assert in Document::updateIsPlayingMedia
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-01 14:13 PDT by youenn fablet
Modified: 2019-05-02 15:35 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.46 KB, patch)
2019-05-01 16:08 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-05-01 14:13:35 PDT 
Add back hasNullReferences() assert in Document::updateIsPlayingMedia
Comment 1 youenn fablet 2019-05-01 16:08:07 PDT 
Created attachment 368727 [details]
Patch
Comment 2 WebKit Commit Bot 2019-05-01 17:20:45 PDT 
Comment on attachment 368727 [details]
Patch

Clearing flags on attachment: 368727

Committed r244860: <https://trac.webkit.org/changeset/244860>
Comment 3 WebKit Commit Bot 2019-05-01 17:20:46 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Darin Adler 2019-05-01 18:34:18 PDT 
Comment on attachment 368727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368727&action=review

> Source/WebCore/Modules/webaudio/AudioContext.cpp:1069
>  ScriptExecutionContext* AudioContext::scriptExecutionContext() const
>  {
> -    return m_isStopScheduled ? 0 : ActiveDOMObject::scriptExecutionContext();
> +    return ActiveDOMObject::scriptExecutionContext();
>  }

Could we come back and just remove this override later?
Comment 5 youenn fablet 2019-05-01 19:34:52 PDT 
(In reply to Darin Adler from comment #4)
> Comment on attachment 368727 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=368727&action=review
> 
> > Source/WebCore/Modules/webaudio/AudioContext.cpp:1069
> >  ScriptExecutionContext* AudioContext::scriptExecutionContext() const
> >  {
> > -    return m_isStopScheduled ? 0 : ActiveDOMObject::scriptExecutionContext();
> > +    return ActiveDOMObject::scriptExecutionContext();
> >  }
> 
> Could we come back and just remove this override later?

Could you clarify your suggestion?
This override is currently needed as AudioContext is an EventTarget.
Comment 6 Darin Adler 2019-05-02 14:33:37 PDT 
Comment on attachment 368727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368727&action=review

>>> Source/WebCore/Modules/webaudio/AudioContext.cpp:1069
>>>  }
>> 
>> Could we come back and just remove this override later?
> 
> Could you clarify your suggestion?
> This override is currently needed as AudioContext is an EventTarget.

OK, then we can’t remove it.
Comment 7 Radar WebKit Bug Importer 2019-05-02 15:35:28 PDT 
<rdar://problem/50424860>