Bug 197437 - Add memory-limited skipping to some tests generating very large strings
Summary: Add memory-limited skipping to some tests generating very large strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-30 13:35 PDT by Stephan Szabo
Modified: 2019-05-01 10:43 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.88 KB, patch)
2019-04-30 13:37 PDT, Stephan Szabo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2019-04-30 13:35:13 PDT 
These three tests showed up as failing on PlayStation due to failing allocations, they each seem to try to make a 1 gig or larger string with padEnd or repeat, so seem like they should also fail in other highly memory limited environments.

Some other tests doing similar things (such as stress/string-overflow-createError.js) have been marked skip if $memoryLimited.
Comment 1 Stephan Szabo 2019-04-30 13:37:44 PDT 
Created attachment 368603 [details]
Patch

Add 
 // @skip if $memoryLimited
for
stress/StringObject-define-length-getter-rope-string-oom.js
stress/create-error-out-of-memory-rope-string.js
stress/string-16bit-repeat-overflow.js
Comment 2 Ross Kirsling 2019-04-30 15:40:26 PDT 
Comment on attachment 368603 [details]
Patch

Looking through other stress tests with values like 2147483644, it certainly appears that this trio was simply overlooked.
Comment 3 WebKit Commit Bot 2019-05-01 10:42:57 PDT 
Comment on attachment 368603 [details]
Patch

Clearing flags on attachment: 368603

Committed r244832: <https://trac.webkit.org/changeset/244832>
Comment 4 WebKit Commit Bot 2019-05-01 10:42:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-05-01 10:43:16 PDT 
<rdar://problem/50374075>