Bug 197341 - Lookup only looking up the first word in selection
Summary: Lookup only looking up the first word in selection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-26 20:07 PDT by Megan Gardner
Modified: 2019-04-27 07:41 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.24 KB, patch)
2019-04-26 20:14 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (3.23 KB, patch)
2019-04-26 20:52 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2019-04-26 20:07:16 PDT 
Lookup only looking up the first word in selection
Comment 1 Megan Gardner 2019-04-26 20:14:06 PDT 
Created attachment 368383 [details]
Patch
Comment 2 Megan Gardner 2019-04-26 20:15:28 PDT 
<rdar://problem/48221414>
Comment 3 Wenson Hsieh 2019-04-26 20:43:37 PDT 
Comment on attachment 368383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368383&action=review

> Source/WebCore/ChangeLog:11
> +        Reveal needs the full range in order to correctly create the item for the popover.

Hmm...from the code change below, it seems like it needs the full range, minus the last character. Or should we actually be passing in the full range of the attributed string?
Comment 4 Megan Gardner 2019-04-26 20:52:10 PDT 
Created attachment 368385 [details]
Patch
Comment 5 WebKit Commit Bot 2019-04-27 07:41:29 PDT 
Comment on attachment 368385 [details]
Patch

Clearing flags on attachment: 368385

Committed r244718: <https://trac.webkit.org/changeset/244718>
Comment 6 WebKit Commit Bot 2019-04-27 07:41:31 PDT 
All reviewed patches have been landed.  Closing bug.