RESOLVED FIXED 197341
Lookup only looking up the first word in selection 
https://bugs.webkit.org/show_bug.cgi?id=197341
Summary Lookup only looking up the first word in selection
Megan Gardner
Reported 2019-04-26 20:07:16 PDT
Lookup only looking up the first word in selection
Attachments
Patch (3.24 KB, patch)
2019-04-26 20:14 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (3.23 KB, patch)
2019-04-26 20:52 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2019-04-26 20:14:06 PDT
Created attachment 368383 [details] Patch
Megan Gardner
Comment 2 2019-04-26 20:15:28 PDT
<rdar://problem/48221414>
Wenson Hsieh
Comment 3 2019-04-26 20:43:37 PDT
Comment on attachment 368383 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368383&action=review > Source/WebCore/ChangeLog:11 > + Reveal needs the full range in order to correctly create the item for the popover. Hmm...from the code change below, it seems like it needs the full range, minus the last character. Or should we actually be passing in the full range of the attributed string?
Megan Gardner
Comment 4 2019-04-26 20:52:10 PDT
Created attachment 368385 [details] Patch
WebKit Commit Bot
Comment 5 2019-04-27 07:41:29 PDT
Comment on attachment 368385 [details] Patch Clearing flags on attachment: 368385 Committed r244718: <https://trac.webkit.org/changeset/244718>
WebKit Commit Bot
Comment 6 2019-04-27 07:41:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.