Bug 197339 - run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
Summary: run-benchmarks should have an intial prep and restore env call for tasks that...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-26 19:00 PDT by Stephanie Lewis
Modified: 2019-04-30 16:54 PDT (History)
6 users (show)

See Also:


Attachments
patch (9.07 KB, patch)
2019-04-26 19:13 PDT, Stephanie Lewis
dewei_zhu: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephanie Lewis 2019-04-26 19:00:02 PDT
Some tasks (like reboots) take a significant amount of time so we should have the ability to run them once and not have to run them in between every iteration.
Comment 1 Stephanie Lewis 2019-04-26 19:13:40 PDT
Created attachment 368380 [details]
patch
Comment 2 Build Bot 2019-04-26 19:15:45 PDT
Attachment 368380 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 dewei_zhu 2019-04-26 19:24:39 PDT
Comment on attachment 368380 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368380&action=review

> Tools/ChangeLog:8
> +	Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire

Four more spaces?
Comment 4 Stephanie Lewis 2019-04-30 16:53:12 PDT
Landed https://trac.webkit.org/changeset/244730/webkit
Comment 5 Radar WebKit Bug Importer 2019-04-30 16:54:18 PDT
<rdar://problem/50355843>