Bug 197330 - Web Inspector: DOM: dragging a node to the console should log the node
Summary: Web Inspector: DOM: dragging a node to the console should log the node
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-26 15:50 PDT by Devin Rousso
Modified: 2019-05-03 19:46 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.37 KB, patch)
2019-04-27 16:44 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (8.60 KB, patch)
2019-05-03 19:05 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-04-26 15:50:19 PDT 
.
Comment 1 Devin Rousso 2019-04-27 16:44:58 PDT 
Created attachment 368414 [details]
Patch

For some reason, the drop doesn't work on anything that isn't normally editable :(
Comment 2 Timothy Hatcher 2019-05-01 12:37:12 PDT 
Comment on attachment 368414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368414&action=review

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:636
> +                let text = domNode.nodeType() === Node.ELEMENT_NODE ? WI.UIString("Selected Element") : WI.UIString("Selected Node");

"Selected Node/Element" => "Dropped Node/Element"?

> Source/WebInspectorUI/UserInterface/Views/QuickConsole.js:189
> +                let text = domNode.nodeType() === Node.ELEMENT_NODE ? WI.UIString("Selected Element") : WI.UIString("Selected Node");

Ditto.
Comment 3 Devin Rousso 2019-05-03 19:05:06 PDT 
Created attachment 369035 [details]
Patch
Comment 4 WebKit Commit Bot 2019-05-03 19:45:13 PDT 
Comment on attachment 369035 [details]
Patch

Clearing flags on attachment: 369035

Committed r244946: <https://trac.webkit.org/changeset/244946>
Comment 5 WebKit Commit Bot 2019-05-03 19:45:15 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-05-03 19:46:24 PDT 
<rdar://problem/50465496>