RESOLVED FIXED197330
Web Inspector: DOM: dragging a node to the console should log the node
https://bugs.webkit.org/show_bug.cgi?id=197330
Summary Web Inspector: DOM: dragging a node to the console should log the node
Devin Rousso
Reported 2019-04-26 15:50:19 PDT
.
Attachments
Patch (7.37 KB, patch)
2019-04-27 16:44 PDT, Devin Rousso
no flags
Patch (8.60 KB, patch)
2019-05-03 19:05 PDT, Devin Rousso
no flags
Devin Rousso
Comment 1 2019-04-27 16:44:58 PDT
Created attachment 368414 [details] Patch For some reason, the drop doesn't work on anything that isn't normally editable :(
Timothy Hatcher
Comment 2 2019-05-01 12:37:12 PDT
Comment on attachment 368414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368414&action=review > Source/WebInspectorUI/UserInterface/Views/LogContentView.js:636 > + let text = domNode.nodeType() === Node.ELEMENT_NODE ? WI.UIString("Selected Element") : WI.UIString("Selected Node"); "Selected Node/Element" => "Dropped Node/Element"? > Source/WebInspectorUI/UserInterface/Views/QuickConsole.js:189 > + let text = domNode.nodeType() === Node.ELEMENT_NODE ? WI.UIString("Selected Element") : WI.UIString("Selected Node"); Ditto.
Devin Rousso
Comment 3 2019-05-03 19:05:06 PDT
WebKit Commit Bot
Comment 4 2019-05-03 19:45:13 PDT
Comment on attachment 369035 [details] Patch Clearing flags on attachment: 369035 Committed r244946: <https://trac.webkit.org/changeset/244946>
WebKit Commit Bot
Comment 5 2019-05-03 19:45:15 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-05-03 19:46:24 PDT
Note You need to log in before you can comment on or make changes to this bug.