Bug 197296 – Web Inspector: DOM: rename "low power" to "display composited"

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

"low power" is not the correct term for this, as the power performance is somewhat implied (not a direct cause).

[Devin Rousso]

Created attachment 368277 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 368277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368277&action=review

rs=me but I think there could be a better name for it still

> Source/JavaScriptCore/ChangeLog:3
> +        Web Inspector: DOM: rename "low power" to "display composted"

Typo in all ChangeLogs from the bug title: "composted" => "composited"

> Source/WebInspectorUI/UserInterface/Images/DisplayCompositedStateChanged.svg:2
> +<?xml version="1.0" encoding="utf-8"?>
> +<!-- Copyright © 2013 Apple Inc. All rights reserved. -->

This year should probably be 2010 instead of 2013. I see it is changing from an [L] to a [D].

> Source/WebInspectorUI/UserInterface/Models/MediaTimelineRecord.js:90
> +        if (this._eventType === WI.MediaTimelineRecord.EventType.DisplayCompositedStateChanged)
> +            return this._isDisplayComposited ? WI.UIString("Started Display Compositing") : WI.UIString("Stopped Display Compositing");

This name sounds confusing to me. What is "Display Compositing"? I like the idea of "Started/Stopped Efficient Video Rendering" or something specific to the video compositing display.

[Devin Rousso]

Comment on attachment 368277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368277&action=review

>> Source/JavaScriptCore/ChangeLog:3
>> +        Web Inspector: DOM: rename "low power" to "display composted"
> 
> Typo in all ChangeLogs from the bug title: "composted" => "composited"

LOOL, nah we should call it "display composted" 😂

>> Source/WebInspectorUI/UserInterface/Images/DisplayCompositedStateChanged.svg:2
>> +<!-- Copyright © 2013 Apple Inc. All rights reserved. -->
> 
> This year should probably be 2010 instead of 2013. I see it is changing from an [L] to a [D].

This was copied from `DOMDocument.svg` which is 2013.

[Devin Rousso]

Created attachment 368996 [details]
Patch

[Devin Rousso]

Created attachment 369007 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 369007 [details]
Patch

Clearing flags on attachment: 369007

Committed r244933: <https://trac.webkit.org/changeset/244933>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50461053>