Bug 197296 - Web Inspector: DOM: rename "low power" to "display composited"
Summary: Web Inspector: DOM: rename "low power" to "display composited"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-25 14:36 PDT by Devin Rousso
Modified: 2019-05-03 16:12 PDT (History)
8 users (show)

See Also:

Attachments
Patch (36.41 KB, patch)
2019-04-25 15:20 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (35.64 KB, patch)
2019-05-03 14:55 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (35.61 KB, patch)
2019-05-03 15:49 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-04-25 14:36:02 PDT 
"low power" is not the correct term for this, as the power performance is somewhat implied (not a direct cause).
Comment 1 Devin Rousso 2019-04-25 15:20:21 PDT 
Created attachment 368277 [details]
Patch
Comment 2 Joseph Pecoraro 2019-04-29 14:23:50 PDT 
Comment on attachment 368277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368277&action=review

rs=me but I think there could be a better name for it still

> Source/JavaScriptCore/ChangeLog:3
> +        Web Inspector: DOM: rename "low power" to "display composted"

Typo in all ChangeLogs from the bug title: "composted" => "composited"

> Source/WebInspectorUI/UserInterface/Images/DisplayCompositedStateChanged.svg:2
> +<?xml version="1.0" encoding="utf-8"?>
> +<!-- Copyright © 2013 Apple Inc. All rights reserved. -->

This year should probably be 2010 instead of 2013. I see it is changing from an [L] to a [D].

> Source/WebInspectorUI/UserInterface/Models/MediaTimelineRecord.js:90
> +        if (this._eventType === WI.MediaTimelineRecord.EventType.DisplayCompositedStateChanged)
> +            return this._isDisplayComposited ? WI.UIString("Started Display Compositing") : WI.UIString("Stopped Display Compositing");

This name sounds confusing to me. What is "Display Compositing"? I like the idea of "Started/Stopped Efficient Video Rendering" or something specific to the video compositing display.
Comment 3 Devin Rousso 2019-04-29 14:39:10 PDT 
Comment on attachment 368277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368277&action=review

>> Source/JavaScriptCore/ChangeLog:3
>> +        Web Inspector: DOM: rename "low power" to "display composted"
> 
> Typo in all ChangeLogs from the bug title: "composted" => "composited"

LOOL, nah we should call it "display composted" 😂

>> Source/WebInspectorUI/UserInterface/Images/DisplayCompositedStateChanged.svg:2
>> +<!-- Copyright © 2013 Apple Inc. All rights reserved. -->
> 
> This year should probably be 2010 instead of 2013. I see it is changing from an [L] to a [D].

This was copied from `DOMDocument.svg` which is 2013.
Comment 4 Devin Rousso 2019-05-03 14:55:21 PDT 
Created attachment 368996 [details]
Patch
Comment 5 Devin Rousso 2019-05-03 15:49:38 PDT 
Created attachment 369007 [details]
Patch
Comment 6 WebKit Commit Bot 2019-05-03 16:08:25 PDT 
Comment on attachment 369007 [details]
Patch

Clearing flags on attachment: 369007

Committed r244933: <https://trac.webkit.org/changeset/244933>
Comment 7 WebKit Commit Bot 2019-05-03 16:08:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-05-03 16:12:11 PDT 
<rdar://problem/50461053>