Bug 196982 - Move MiG .def files into their own "Copy files" build step
Summary: Move MiG .def files into their own "Copy files" build step
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on: 197031
Blocks:
  Show dependency tree / graph
 
Reported: 2019-04-16 13:46 PDT by Keith Rollin
Modified: 2019-04-18 13:26 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.17 KB, patch)
2019-04-16 14:01 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
Patch (8.13 KB, patch)
2019-04-18 12:26 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-04-16 13:46:16 PDT 
WebKitLegacy's MiG files need to be processed differently from the other files in the "Copy Headers" build phase, so move them into their own "Copy Files" build phase. This arrangement removes them from any post-processing performed on the main group of headers.
Comment 1 Radar WebKit Bug Importer 2019-04-16 13:51:31 PDT 
<rdar://problem/49952579>
Comment 2 Keith Rollin 2019-04-16 14:01:48 PDT 
Created attachment 367567 [details]
Patch
Comment 3 Alex Christensen 2019-04-17 09:18:51 PDT 
Comment on attachment 367567 [details]
Patch

I was just thinking we don't have enough build steps.  We need more.
Comment 4 WebKit Commit Bot 2019-04-17 10:58:14 PDT 
Comment on attachment 367567 [details]
Patch

Clearing flags on attachment: 367567

Committed r244386: <https://trac.webkit.org/changeset/244386>
Comment 5 WebKit Commit Bot 2019-04-17 10:58:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2019-04-17 12:44:10 PDT 
Re-opened since this is blocked by bug 197031
Comment 7 Keith Rollin 2019-04-18 12:26:52 PDT 
Created attachment 367743 [details]
Patch
Comment 8 WebKit Commit Bot 2019-04-18 13:26:28 PDT 
Comment on attachment 367743 [details]
Patch

Clearing flags on attachment: 367743

Committed r244432: <https://trac.webkit.org/changeset/244432>
Comment 9 WebKit Commit Bot 2019-04-18 13:26:30 PDT 
All reviewed patches have been landed.  Closing bug.