Bug 196955 - Add a query string nonce to LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html to address flakiness
Summary: Add a query string nonce to LayoutTests/http/tests/adClickAttribution/send-at...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-15 20:38 PDT by John Wilander
Modified: 2019-04-15 21:24 PDT (History)
2 users (show)

See Also:

Attachments
Patch for landing (7.54 KB, patch)
2019-04-15 20:44 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2019-04-15 20:38:54 PDT 
As noted in comment https://bugs.webkit.org/show_bug.cgi?id=196838#c18, LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html is a flaky failure. We should add a nonce to the file created so that test runs cannot mess with each other.
Comment 1 John Wilander 2019-04-15 20:44:06 PDT 
Created attachment 367494 [details]
Patch for landing
Comment 2 Radar WebKit Bug Importer 2019-04-15 20:46:52 PDT 
<rdar://problem/49928896>
Comment 3 Radar WebKit Bug Importer 2019-04-15 20:47:03 PDT 
<rdar://problem/49928898>
Comment 4 WebKit Commit Bot 2019-04-15 21:24:29 PDT 
Comment on attachment 367494 [details]
Patch for landing

Clearing flags on attachment: 367494

Committed r244325: <https://trac.webkit.org/changeset/244325>
Comment 5 WebKit Commit Bot 2019-04-15 21:24:30 PDT 
All reviewed patches have been landed.  Closing bug.