Bug 196782 - [iOS] Fix iokit-get-properties sandbox violations
Summary: [iOS] Fix iokit-get-properties sandbox violations
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-10 14:11 PDT by Per Arne Vollan
Modified: 2019-04-10 15:50 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2019-04-10 14:13 PDT, Per Arne Vollan
bfulgham: review+
Details | Formatted Diff | Diff
Patch (2.52 KB, patch)
2019-04-10 15:11 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-04-10 14:11:27 PDT
A few iokit properties needs to be added to the iOS sandbox.
Comment 1 Per Arne Vollan 2019-04-10 14:11:45 PDT
rdar://problem/49497720
Comment 2 Per Arne Vollan 2019-04-10 14:13:31 PDT
Created attachment 367161 [details]
Patch
Comment 3 Brent Fulgham 2019-04-10 15:00:44 PDT
Comment on attachment 367161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367161&action=review

r=me

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:300
> +    (iokit-property "graphics-featureset-class") ;; <rdar://problem/49497720>

In general, it's probably nicer to keep these all in alphabetical order (just for ease of locating them in the future)
Comment 4 Per Arne Vollan 2019-04-10 15:11:43 PDT
Created attachment 367169 [details]
Patch
Comment 5 Brent Fulgham 2019-04-10 15:16:55 PDT
Comment on attachment 367169 [details]
Patch

Very nice! r=me.
Comment 6 Per Arne Vollan 2019-04-10 15:27:17 PDT
Comment on attachment 367169 [details]
Patch

Thanks for reviewing!
Comment 7 WebKit Commit Bot 2019-04-10 15:50:10 PDT
Comment on attachment 367169 [details]
Patch

Clearing flags on attachment: 367169

Committed r244159: <https://trac.webkit.org/changeset/244159>