Bug 196741 - [CMake] WEBKIT_COMPUTE_SOURCES should use the target's derived sources directory
Summary: [CMake] WEBKIT_COMPUTE_SOURCES should use the target's derived sources directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks: 196704
  Show dependency tree / graph
 
Reported: 2019-04-09 12:24 PDT by Don Olmstead
Modified: 2019-04-09 18:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.53 KB, patch)
2019-04-09 12:51 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2019-04-09 12:24:00 PDT 
WEBKIT_COMPUTE_SOURCES is using ${DERIVED_SOURCES_DIR} directly. Instead it should rely on the directory specified by the target.
Comment 1 Don Olmstead 2019-04-09 12:51:29 PDT 
Created attachment 367065 [details]
Patch
Comment 2 WebKit Commit Bot 2019-04-09 18:28:38 PDT 
Comment on attachment 367065 [details]
Patch

Clearing flags on attachment: 367065

Committed r244103: <https://trac.webkit.org/changeset/244103>
Comment 3 WebKit Commit Bot 2019-04-09 18:28:40 PDT 
All reviewed patches have been landed.  Closing bug.