RESOLVED FIXED196709
[ews-build] Scripts using Buildbot API have CORS error 
https://bugs.webkit.org/show_bug.cgi?id=196709
Summary [ews-build] Scripts using Buildbot API have CORS error
Aakash Jain
Reported 2019-04-08 14:45:38 PDT
Any script using Buildbot API will have CORS error, since buildbot is not setting CORS header appropriately. We need to set allowed_origins in Buildbot configuration as per: http://docs.buildbot.net/latest/manual/configuration/www.html#web-server
Attachments
Patch (1.07 KB, patch)
2019-04-08 14:48 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-04-08 14:45:45 PDT
<rdar://problem/49710473>
Aakash Jain
Comment 2 2019-04-08 14:48:43 PDT
Created attachment 366985 [details] Patch
Alexey Proskuryakov
Comment 3 2019-04-08 15:03:02 PDT
Comment on attachment 366985 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366985&action=review > Tools/BuildSlaveSupport/ews-build/master.cfg:14 > +c['www'] = dict(port=8010, allowed_origins=["*"]) This has security considerations that I wouldn't want to think through unless I have to. What are the scripts that hit the error? Only JavaScript running in the browser is strictly subject to CORS. Some scripting also enables those checks, but that can always be disabled.
Alexey Proskuryakov
Comment 4 2019-04-08 16:35:24 PDT
Comment on attachment 366985 [details] Patch OK, I think that this is fine. We have the same rules on build.webkit.org anyway.
WebKit Commit Bot
Comment 5 2019-04-08 17:42:33 PDT
Comment on attachment 366985 [details] Patch Clearing flags on attachment: 366985 Committed r244060: <https://trac.webkit.org/changeset/244060>
WebKit Commit Bot
Comment 6 2019-04-08 17:42:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.