Bug 19667 - SVG Filter code clean up
Summary: SVG Filter code clean up
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Alex Mathews
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-19 01:43 PDT by Alex Mathews
Modified: 2009-01-18 09:58 PST (History)
1 user (show)

See Also:

Attachments
Round 1 of SVG Filter clean up (59.79 KB, patch)
2008-06-19 01:45 PDT, Alex Mathews 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Mathews 2008-06-19 01:43:31 PDT 
Just bringing the SVG Filter code up to date with newer webkit standards like RefPtr/PassRefPtr as well as adding 'create' functions and coding style fixes, among other things. There will probably be many rounds of this as I go through and clean it up.
Comment 1 Alex Mathews 2008-06-19 01:45:40 PDT 
Created attachment 21831 [details]
Round 1 of SVG Filter clean up
Comment 2 Oliver Hunt 2008-06-19 01:53:51 PDT 
Comment on attachment 21831 [details]
Round 1 of SVG Filter clean up

r=me
Comment 3 Michelangelo De Simone 2008-06-19 02:20:31 PDT 
Congratulations!
Comment 4 Oliver Hunt 2008-06-19 02:56:10 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	C	WebCore/svg/graphics/filters/SVGFETile.h => WebCore/svg/graphics/filters/SVGFETile.cpp
	M	WebCore/ChangeLog
	M	WebCore/WebCore.xcodeproj/project.pbxproj
	M	WebCore/svg/SVGFEBlendElement.cpp
	M	WebCore/svg/SVGFEBlendElement.h
	M	WebCore/svg/SVGFEColorMatrixElement.cpp
	M	WebCore/svg/SVGFEColorMatrixElement.h
	M	WebCore/svg/SVGFEComponentTransferElement.cpp
	M	WebCore/svg/SVGFEComponentTransferElement.h
	M	WebCore/svg/SVGFECompositeElement.cpp
	M	WebCore/svg/SVGFECompositeElement.h
	M	WebCore/svg/SVGFEDiffuseLightingElement.cpp
	M	WebCore/svg/SVGFEDiffuseLightingElement.h
	M	WebCore/svg/SVGFEDisplacementMapElement.cpp
	M	WebCore/svg/SVGFEDisplacementMapElement.h
	M	WebCore/svg/SVGFEFloodElement.cpp
	M	WebCore/svg/SVGFEFloodElement.h
	M	WebCore/svg/SVGFEGaussianBlurElement.cpp
	M	WebCore/svg/SVGFEGaussianBlurElement.h
	M	WebCore/svg/SVGFEImageElement.cpp
	M	WebCore/svg/SVGFEImageElement.h
	M	WebCore/svg/SVGFEMergeElement.cpp
	M	WebCore/svg/SVGFEMergeElement.h
	M	WebCore/svg/SVGFEOffsetElement.cpp
	M	WebCore/svg/SVGFEOffsetElement.h
	M	WebCore/svg/SVGFESpecularLightingElement.cpp
	M	WebCore/svg/SVGFESpecularLightingElement.h
	M	WebCore/svg/SVGFETileElement.cpp
	M	WebCore/svg/SVGFETileElement.h
	M	WebCore/svg/SVGFETurbulenceElement.cpp
	M	WebCore/svg/SVGFETurbulenceElement.h
	M	WebCore/svg/graphics/filters/SVGFEBlend.cpp
	M	WebCore/svg/graphics/filters/SVGFEBlend.h
	M	WebCore/svg/graphics/filters/SVGFEColorMatrix.cpp
	M	WebCore/svg/graphics/filters/SVGFEColorMatrix.h
	M	WebCore/svg/graphics/filters/SVGFEComponentTransfer.cpp
	M	WebCore/svg/graphics/filters/SVGFEComponentTransfer.h
	M	WebCore/svg/graphics/filters/SVGFEComposite.cpp
	M	WebCore/svg/graphics/filters/SVGFEComposite.h
	M	WebCore/svg/graphics/filters/SVGFEConvolveMatrix.cpp
	M	WebCore/svg/graphics/filters/SVGFEConvolveMatrix.h
	M	WebCore/svg/graphics/filters/SVGFEDiffuseLighting.cpp
	M	WebCore/svg/graphics/filters/SVGFEDiffuseLighting.h
	M	WebCore/svg/graphics/filters/SVGFEDisplacementMap.cpp
	M	WebCore/svg/graphics/filters/SVGFEDisplacementMap.h
	M	WebCore/svg/graphics/filters/SVGFEFlood.cpp
	M	WebCore/svg/graphics/filters/SVGFEFlood.h
	M	WebCore/svg/graphics/filters/SVGFEGaussianBlur.cpp
	M	WebCore/svg/graphics/filters/SVGFEGaussianBlur.h
	M	WebCore/svg/graphics/filters/SVGFEImage.cpp
	M	WebCore/svg/graphics/filters/SVGFEImage.h
	M	WebCore/svg/graphics/filters/SVGFEMerge.cpp
	M	WebCore/svg/graphics/filters/SVGFEMerge.h
	M	WebCore/svg/graphics/filters/SVGFEOffset.cpp
	M	WebCore/svg/graphics/filters/SVGFEOffset.h
	M	WebCore/svg/graphics/filters/SVGFESpecularLighting.cpp
	M	WebCore/svg/graphics/filters/SVGFESpecularLighting.h
	M	WebCore/svg/graphics/filters/SVGFETile.h
	M	WebCore/svg/graphics/filters/SVGFETurbulence.cpp
	M	WebCore/svg/graphics/filters/SVGFETurbulence.h
	M	WebCore/svg/graphics/filters/SVGFilterEffect.h
	M	WebCore/svg/graphics/filters/SVGLightSource.h
Committed r34656

Wooo!!!!