RESOLVED FIXED 196617
[JSC] DFG should respect node's strict flag 
https://bugs.webkit.org/show_bug.cgi?id=196617
Summary [JSC] DFG should respect node's strict flag
Yusuke Suzuki
Reported 2019-04-04 12:13:29 PDT
...
Attachments
Patch (25.95 KB, patch)
2019-04-08 19:23 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-04-07 03:26:03 PDT
Seems like a DFG bug. Looking into it.
Yusuke Suzuki
Comment 2 2019-04-08 18:35:35 PDT
Found the bug. DFGSpeculativeJIT has some code like, `m_jit.codeBlock()->isStrictMode()`. This is obviously wrong since it does not consider inlined CodeBlocks.
Yusuke Suzuki
Comment 3 2019-04-08 19:23:34 PDT
Created attachment 367014 [details] Patch
EWS Watchlist
Comment 4 2019-04-08 19:27:13 PDT
Attachment 367014 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:13: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzer [changelog/unwantedsecurityterms] [3] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 5 2019-04-08 20:15:55 PDT
Comment on attachment 367014 [details] Patch r=me
Yusuke Suzuki
Comment 6 2019-04-08 20:23:21 PDT
Committed r244067: <https://trac.webkit.org/changeset/244067>
Radar WebKit Bug Importer
Comment 7 2019-04-08 20:24:24 PDT
<rdar://problem/49722731>
Note You need to log in before you can comment on or make changes to this bug.