Bug 196613 - [macOS][iOS] Add filter to syscall sandbox rule
Summary: [macOS][iOS] Add filter to syscall sandbox rule
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-04 10:47 PDT by Per Arne Vollan
Modified: 2019-04-04 15:51 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.43 KB, patch)
2019-04-04 10:50 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (2.43 KB, patch)
2019-04-04 11:08 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-04-04 10:47:03 PDT
This will restrict the existing sandbox rule for the syscall.
Comment 1 Per Arne Vollan 2019-04-04 10:47:27 PDT
rdar://problem/49531420
Comment 2 Per Arne Vollan 2019-04-04 10:50:20 PDT
Created attachment 366727 [details]
Patch
Comment 3 Per Arne Vollan 2019-04-04 11:08:38 PDT
Created attachment 366728 [details]
Patch
Comment 4 Brent Fulgham 2019-04-04 11:17:40 PDT
Comment on attachment 366728 [details]
Patch

Yes! R=me!
Comment 5 Per Arne Vollan 2019-04-04 11:44:05 PDT
Comment on attachment 366728 [details]
Patch

Thanks for reviewing!
Comment 6 WebKit Commit Bot 2019-04-04 12:13:44 PDT
Comment on attachment 366728 [details]
Patch

Clearing flags on attachment: 366728

Committed r243888: <https://trac.webkit.org/changeset/243888>
Comment 7 WebKit Commit Bot 2019-04-04 12:13:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Ryan Haddad 2019-04-04 15:51:32 PDT
Reverted r243888 for reason:

Introduced layout test crashes.

Committed r243916: <https://trac.webkit.org/changeset/243916>
Comment 9 Ryan Haddad 2019-04-04 15:51:58 PDT
(In reply to Ryan Haddad from comment #8)
> Reverted r243888 for reason:
> 
> Introduced layout test crashes.
> 
> Committed r243916: <https://trac.webkit.org/changeset/243916>

Details in radar.