Bug 196501 - [ews-build] Configure buildbot try credentials in environment variables
Summary: [ews-build] Configure buildbot try credentials in environment variables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-02 11:27 PDT by Aakash Jain
Modified: 2019-04-02 14:10 PDT (History)
7 users (show)

See Also:


Attachments
Patch (3.17 KB, patch)
2019-04-02 11:30 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-04-02 11:27:42 PDT
Currently ews-build use very weak username/password for buildbot try. This password is hard-coded in source code. We should instead read the credentials from environment variables and configure strong password.
Comment 1 Aakash Jain 2019-04-02 11:30:18 PDT
Created attachment 366509 [details]
Patch
Comment 2 WebKit Commit Bot 2019-04-02 14:09:23 PDT
Comment on attachment 366509 [details]
Patch

Clearing flags on attachment: 366509

Committed r243759: <https://trac.webkit.org/changeset/243759>
Comment 3 WebKit Commit Bot 2019-04-02 14:09:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-04-02 14:10:18 PDT
<rdar://problem/49533667>